Hi,
I would like to deprecate php_dirname() in 5_3 as it has been moved to
the engine (zend_dirname()). Any concerns?
5_3: http://lars.schokokeks.org/php/5_3-deprecating-php_dirname.diff
HEAD: http://lars.schokokeks.org/php/HEAD-removing-php_dirname.diff
cu, Lars
hi,
Hi,
I would like to deprecate php_dirname() in 5_3 as it has been moved to
the engine (zend_dirname()). Any concerns?5_3: http://lars.schokokeks.org/php/5_3-deprecating-php_dirname.diff
HEAD: http://lars.schokokeks.org/php/HEAD-removing-php_dirname.diff
What's the gain of this change besides forcing code change and adding
more #ifdef? :)
Cheers,
Hi Pierre,
Am Donnerstag, den 06.03.2008, 01:22 +0100 schrieb Pierre Joye:
[...]
5_3: http://lars.schokokeks.org/php/5_3-deprecating-php_dirname.diff
HEAD: http://lars.schokokeks.org/php/HEAD-removing-php_dirname.diffWhat's the gain of this change besides forcing code change and adding
more #ifdef? :)
Simply one useless alias less.
cu, Lars
Hi Pierre,
Am Donnerstag, den 06.03.2008, 01:22 +0100 schrieb Pierre Joye:
[...]5_3: http://lars.schokokeks.org/php/5_3-deprecating-php_dirname.diff
HEAD: http://lars.schokokeks.org/php/HEAD-removing-php_dirname.diffWhat's the gain of this change besides forcing code change and adding
more #ifdef? :)Simply one useless alias less.
I'm talking about extension developers. We will all have to add yet
another #ifdef for this function, in the implementation or to define
php_dirname to keep the implementation clean(er). As it is good to
clean up codes, I'm not sure to remove this function is a good thing.
Cheers,
Hi Pierre,
Am Donnerstag, den 06.03.2008, 01:30 +0100 schrieb Pierre Joye:
[...]
I'm talking about extension developers. We will all have to add yet
another #ifdef for this function, in the implementation or to define
php_dirname to keep the implementation clean(er). As it is good to
clean up codes, I'm not sure to remove this function is a good thing.
That's why I suggest removing it in 6, and deprecating it from now on.
As 6 "will break everything anyway".
cu, Lars
Hi Pierre,
Am Donnerstag, den 06.03.2008, 01:30 +0100 schrieb Pierre Joye:
[...]I'm talking about extension developers. We will all have to add yet
another #ifdef for this function, in the implementation or to define
php_dirname to keep the implementation clean(er). As it is good to
clean up codes, I'm not sure to remove this function is a good thing.That's why I suggest removing it in 6, and deprecating it from now on.
As 6 "will break everything anyway".
I go it but there is no easy to deprecate an internal function. Except
to spare two #define php_(u)_dirname in HEAD, I still see no gain :)
I'm talking about extension developers. We will all have to add yet
another #ifdef for this function, in the implementation or to define
php_dirname to keep the implementation clean(er). As it is good to
clean up codes, I'm not sure to remove this function is a good thing.That's why I suggest removing it in 6, and deprecating it from now on.
As 6 "will break everything anyway".I go it but there is no easy to deprecate an internal function. Except
to spare two #define php_(u)_dirname in HEAD, I still see no gain :)
Perhaps it's time to make a "compatibility" extension with all those
ifdefs everywhere and engine hooks.
--
David,
Re-read what you are replying.
I'm talking about extension developers. We will all have to add yet
another #ifdef for this function, in the implementation or to
define
php_dirname to keep the implementation clean(er). As it is good to
clean up codes, I'm not sure to remove this function is a good
thing.
That's why I suggest removing it in 6, and deprecating it from now
on.
As 6 "will break everything anyway".
I go it but there is no easy to deprecate an internal function.
Except
to spare two #define php_(u)_dirname in HEAD, I still see no gain :)
Perhaps it's time to make a "compatibility" extension with all those
ifdefs everywhere and engine hooks.
I'll +1 that. I'll even volunteer to maintain it, if someone who knows
the engine better can give me a framework to start from.
-- Gwynne, Daughter of the Code
"This whole world is an asylum for the incurable."
I'm talking about extension developers. We will all have to add yet
another #ifdef for this function, in the implementation or to define
php_dirname to keep the implementation clean(er). As it is good to
clean up codes, I'm not sure to remove this function is a good thing.That's why I suggest removing it in 6, and deprecating it from now on.
As 6 "will break everything anyway".I go it but there is no easy to deprecate an internal function. Except
to spare two #define php_(u)_dirname in HEAD, I still see no gain :)Perhaps it's time to make a "compatibility" extension with all those
ifdefs everywhere and engine hooks.
That's fine, as long as nothing breaks. I'm with Pierre on this one.
regards,
Derick
--
Derick Rethans
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org