Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:35993
Return-Path: <gwynne@wanderingknights.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 96825 invoked from network); 6 Mar 2008 02:56:59 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 6 Mar 2008 02:56:59 -0000
Authentication-Results: pb1.pair.com header.from=gwynne@wanderingknights.org; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=gwynne@wanderingknights.org; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain wanderingknights.org from 208.97.132.145 cause and error)
X-PHP-List-Original-Sender: gwynne@wanderingknights.org
X-Host-Fingerprint: 208.97.132.145 sd-green-bigip-145.dreamhost.com Linux 2.4/2.6
Received: from [208.97.132.145] ([208.97.132.145:57975] helo=postalmail-a2.g.dreamhost.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 7A/45-06151-A7D5FC74 for <internals@lists.php.net>; Wed, 05 Mar 2008 21:56:59 -0500
Received: from [192.168.2.192] (c-76-118-64-137.hsd1.ma.comcast.net [76.118.64.137])
	by postalmail-a2.g.dreamhost.com (Postfix) with ESMTP id A3B0217DD6;
	Wed,  5 Mar 2008 18:56:53 -0800 (PST)
Cc: "Pierre Joye" <pierre.php@gmail.com>,
	"Lars Strojny" <lars@strojny.net>,
	"PHP Developers Mailing List" <internals@lists.php.net>
Message-ID: <01F20130-DAD0-413A-A46D-D57181486396@wanderingknights.org>
To: David Coallier <davidc@php.net>
In-Reply-To: <b5f7bf6c0803051852p3c52d19bhcb543b6efb8981c3@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v919.2)
Date: Wed, 5 Mar 2008 21:56:52 -0500
References: <1204759149.27088.2.camel@localhost> <fe05d1540803051622v3e33bf5dvfa6dd4b620b47324@mail.gmail.com> <1204763172.31278.2.camel@localhost> <fe05d1540803051630k461bbeak83e0e1ca223afaa3@mail.gmail.com> <1204763576.31278.5.camel@localhost> <fe05d1540803051636g3833e13en2435b3777541a54e@mail.gmail.com> <b5f7bf6c0803051852p3c52d19bhcb543b6efb8981c3@mail.gmail.com>
X-Mailer: Apple Mail (2.919.2)
Subject: Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD
From: gwynne@wanderingknights.org (Gwynne Raskind)

On Mar 5, 2008, at 9:52 PM, David Coallier wrote:
>>>> I'm talking about extension developers. We will all have to add yet
>>>> another #ifdef for this function, in the implementation or to  
>>>> define
>>>> php_dirname to keep the implementation clean(er). As it is good to
>>>> clean up codes, I'm not sure to remove this function is a good  
>>>> thing.
>>> That's why I suggest removing it in 6, and deprecating it from now  
>>> on.
>>> As 6 "will break everything anyway".
>> I go it but there is no easy to deprecate an internal function.  
>> Except
>> to spare two  #define php_(u)_dirname in HEAD, I still see no gain :)
> Perhaps it's time to make a "compatibility" extension with all those
> ifdefs everywhere and engine hooks.


I'll +1 that. I'll even volunteer to maintain it, if someone who knows  
the engine better can give me a framework to start from.

-- Gwynne, Daughter of the Code
"This whole world is an asylum for the incurable."