Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:36004 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14980 invoked from network); 6 Mar 2008 15:33:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Mar 2008 15:33:34 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.94.239.7 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.94.239.7 mail.jdi-ict.nl Linux 2.6 Received: from [82.94.239.7] ([82.94.239.7:38475] helo=mail.jdi-ict.nl) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D3/9C-06151-7CE00D74 for ; Thu, 06 Mar 2008 10:33:29 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.jdi-ict.nl (8.13.7/8.12.11) with ESMTP id m26FXHRR014965; Thu, 6 Mar 2008 16:33:17 +0100 Date: Thu, 6 Mar 2008 16:33:21 +0100 (CET) X-X-Sender: derick@kossu.ez.no To: David Coallier cc: Pierre Joye , Lars Strojny , PHP Developers Mailing List In-Reply-To: Message-ID: References: <1204759149.27088.2.camel@localhost> <1204763172.31278.2.camel@localhost> <1204763576.31278.5.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Subject: Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD From: derick@php.net (Derick Rethans) On Wed, 5 Mar 2008, David Coallier wrote: > > > > I'm talking about extension developers. We will all have to add yet > > > > another #ifdef for this function, in the implementation or to define > > > > php_dirname to keep the implementation clean(er). As it is good to > > > > clean up codes, I'm not sure to remove this function is a good thing. > > > > > > That's why I suggest removing it in 6, and deprecating it from now on. > > > As 6 "will break everything anyway". > > > > I go it but there is no easy to deprecate an internal function. Except > > to spare two #define php_(u)_dirname in HEAD, I still see no gain :) > > Perhaps it's time to make a "compatibility" extension with all those > ifdefs everywhere and engine hooks. That's fine, as long as nothing breaks. I'm with Pierre on this one. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org