TSRM mutex return value inconsitencies

17 years ago by Scott MacVicar — view source

unread

Hi,

While doing some threaded work I noticed that tsrm_mutex_lock and
tsrm_mutex_unlock return different values for Windows and Linux (using
pthread).

Attached is the patch to make everything more pthread like, it will
return 0 for success and any other value is an error.

Windows, GNU Portable Threads and the NSAPI implementations were
returning incorrect values.

Scott

17 years ago by Dmitry Stogov — view source

unread

Hi Scott,

I'm fine with your patch.
Please commit it, or let me know if you like me to commit it.

Thanks. Dmitry.

Scott MacVicar wrote:

Hi,

While doing some threaded work I noticed that tsrm_mutex_lock and
tsrm_mutex_unlock return different values for Windows and Linux (using
pthread).

Attached is the patch to make everything more pthread like, it will
return 0 for success and any other value is an error.

Windows, GNU Portable Threads and the NSAPI implementations were
returning incorrect values.

Scott

17 years ago by Scott MacVicar — view source

unread

Hi Dmitry,

I don't have karma for TSRM only php-src.

Scott

Dmitry Stogov wrote:

Hi Scott,

I'm fine with your patch.
Please commit it, or let me know if you like me to commit it.

Thanks. Dmitry.

Scott MacVicar wrote:

Hi,

While doing some threaded work I noticed that tsrm_mutex_lock and
tsrm_mutex_unlock return different values for Windows and Linux (using
pthread).

Attached is the patch to make everything more pthread like, it will
return 0 for success and any other value is an error.

Windows, GNU Portable Threads and the NSAPI implementations were
returning incorrect values.

Scott

17 years ago by Antony Dovgal — view source

unread

Hi Dmitry,

I don't have karma for TSRM only php-src.

Patch committed, thanks a lot.

Ilia, should I commit it to 5_2?
This looks more like a regular bugfix, not as an improvement.

--
Wbr,
Antony Dovgal