Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35237 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87858 invoked by uid 1010); 6 Feb 2008 10:58:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 87843 invoked from network); 6 Feb 2008 10:58:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Feb 2008 10:58:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:26717] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 59/B1-03555-9E299A74 for ; Wed, 06 Feb 2008 05:58:50 -0500 Received: (qmail 16269 invoked from network); 6 Feb 2008 10:58:45 -0000 Received: from unknown (HELO ?10.1.20.30?) (10.1.20.30) by cvs.zend.com with SMTP; 6 Feb 2008 10:58:45 -0000 Message-ID: <47A992E4.2040800@zend.com> Date: Wed, 06 Feb 2008 13:58:44 +0300 User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Scott MacVicar CC: php-dev References: <47A869B5.1000907@php.net> In-Reply-To: <47A869B5.1000907@php.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] TSRM mutex return value inconsitencies From: dmitry@zend.com (Dmitry Stogov) Hi Scott, I'm fine with your patch. Please commit it, or let me know if you like me to commit it. Thanks. Dmitry. Scott MacVicar wrote: > Hi, > > While doing some threaded work I noticed that tsrm_mutex_lock and > tsrm_mutex_unlock return different values for Windows and Linux (using > pthread). > > Attached is the patch to make everything more pthread like, it will > return 0 for success and any other value is an error. > > Windows, GNU Portable Threads and the NSAPI implementations were > returning incorrect values. > > Scott >