Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:35247 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40494 invoked by uid 1010); 6 Feb 2008 13:13:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40479 invoked from network); 6 Feb 2008 13:13:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Feb 2008 13:13:47 -0000 Authentication-Results: pb1.pair.com header.from=scottmac@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=scottmac@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 72.232.140.210 as permitted sender) X-PHP-List-Original-Sender: scottmac@php.net X-Host-Fingerprint: 72.232.140.210 midden.org.uk Received: from [72.232.140.210] ([72.232.140.210:38459] helo=lovelace.midden.org.uk) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 96/7A-03555-782B9A74 for ; Wed, 06 Feb 2008 08:13:47 -0500 Received: from office.vbulletin.com ([217.155.246.60] helo=[10.0.0.116]) by lovelace.midden.org.uk with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JMk5s-00050V-IN; Wed, 06 Feb 2008 13:13:40 +0000 Message-ID: <47A9B27C.2070000@php.net> Date: Wed, 06 Feb 2008 13:13:32 +0000 User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Dmitry Stogov CC: php-dev References: <47A869B5.1000907@php.net> <47A992E4.2040800@zend.com> In-Reply-To: <47A992E4.2040800@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] TSRM mutex return value inconsitencies From: scottmac@php.net (Scott MacVicar) Hi Dmitry, I don't have karma for TSRM only php-src. Scott Dmitry Stogov wrote: > Hi Scott, > > I'm fine with your patch. > Please commit it, or let me know if you like me to commit it. > > Thanks. Dmitry. > > Scott MacVicar wrote: >> Hi, >> >> While doing some threaded work I noticed that tsrm_mutex_lock and >> tsrm_mutex_unlock return different values for Windows and Linux (using >> pthread). >> >> Attached is the patch to make everything more pthread like, it will >> return 0 for success and any other value is an error. >> >> Windows, GNU Portable Threads and the NSAPI implementations were >> returning incorrect values. >> >> Scott >> >