Hi Marcus,
Could you please fix PHP6 build.
You broke it day or two ago :(
After your modifications of ext/reflection PHP always emits error messages
about method incompatibilities.
I am not sure if static methods must be checked for compatibility (I mean
ReflectionMethod::export()), but ReflectionMethod::invoke() is not static.
Thanks. Dmitry.
Hi Marcus,
Could you please fix PHP6 build.
You broke it day or two ago :(
Yeah, sorry about that, was my fault (it broke 5_2 to).
Actually, this bug has been there for a while, but the engine didn't
catch it since it had no idea which parameters the methods had.
I have a patch ready, which moves all methods from ReflectionFunction
into ReflectionFunctionAbstract (except from export, invoke &
invokeArgs), http://php.is/bugs/reflection/reflections.patch.txt, just
need someone to review it before I commit it.
-Hannes
After your modifications of ext/reflection PHP always emits error messages
about method incompatibilities.I am not sure if static methods must be checked for compatibility (I mean
ReflectionMethod::export()), but ReflectionMethod::invoke() is not static.Thanks. Dmitry.
Hello Hannes,
the patch looks good and solves the issues as far as i can tell. We
might want to make the abstract part an interface but we'll see. Just
commit for now.
best regards
marcus
Friday, June 9, 2006, 5:06:02 PM, you wrote:
Hi Marcus,
Could you please fix PHP6 build.
You broke it day or two ago :(
Yeah, sorry about that, was my fault (it broke 5_2 to).
Actually, this bug has been there for a while, but the engine didn't
catch it since it had no idea which parameters the methods had.
I have a patch ready, which moves all methods from ReflectionFunction
into ReflectionFunctionAbstract (except from export, invoke &
invokeArgs), http://php.is/bugs/reflection/reflections.patch.txt, just
need someone to review it before I commit it.
-Hannes
After your modifications of ext/reflection PHP always emits error messages
about method incompatibilities.I am not sure if static methods must be checked for compatibility (I mean
ReflectionMethod::export()), but ReflectionMethod::invoke() is not static.Thanks. Dmitry.
--
Best regards,
Marcus