Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24043 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86376 invoked by uid 1010); 9 Jun 2006 15:06:07 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 86361 invoked from network); 9 Jun 2006 15:06:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Jun 2006 15:06:07 -0000 X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 66.249.82.192 wx-out-0102.google.com Linux 2.4/2.6 Received: from ([66.249.82.192:48895] helo=wx-out-0102.google.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id BF/88-30619-D5E89844 for ; Fri, 09 Jun 2006 11:06:05 -0400 Received: by wx-out-0102.google.com with SMTP id s14so587532wxc for ; Fri, 09 Jun 2006 08:06:02 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=n5p5xL2eIrphcGrhPPYNiR8mKblMedhlxe7LwY/b+mu2W8SFNDJODBSc8LulITuFyb9fSLIAEFQsp455S/lhTbs9Yo6HAdtwZsVBBqDZe5XYnI0V7KLboqYQ27Sd0772FyViQohZdVkK+bgSVjMOUyjrGw7ddm2OJXnNVA+FdZk= Received: by 10.70.73.4 with SMTP id v4mr3603775wxa; Fri, 09 Jun 2006 08:06:02 -0700 (PDT) Received: by 10.70.91.5 with HTTP; Fri, 9 Jun 2006 08:06:02 -0700 (PDT) Message-ID: <7f3ed2c30606090806w36158503h12ede2ae8bcf21e7@mail.gmail.com> Date: Fri, 9 Jun 2006 17:06:02 +0200 To: "Dmitry Stogov" Cc: "Marcus Boerger" , "Andi Gutmans" , internals@lists.php.net In-Reply-To: <000001c68bd3$667bfd80$6e02a8c0@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <000001c68bd3$667bfd80$6e02a8c0@thinkpad> Subject: Re: [PHP-DEV] PHP6 broken From: hannes.magnusson@gmail.com ("Hannes Magnusson") On 6/9/06, Dmitry Stogov wrote: > Hi Marcus, > > Could you please fix PHP6 build. > You broke it day or two ago :( Yeah, sorry about that, was my fault (it broke 5_2 to). Actually, this bug has been there for a while, but the engine didn't catch it since it had no idea which parameters the methods had. I have a patch ready, which moves all methods from ReflectionFunction into ReflectionFunctionAbstract (except from export, invoke & invokeArgs), http://php.is/bugs/reflection/reflections.patch.txt, just need someone to review it before I commit it. -Hannes > > After your modifications of ext/reflection PHP always emits error messages > about method incompatibilities. > > I am not sure if static methods must be checked for compatibility (I mean > ReflectionMethod::export()), but ReflectionMethod::invoke() is not static. > > Thanks. Dmitry. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >