Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24069 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39937 invoked by uid 1010); 10 Jun 2006 00:16:24 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 39922 invoked from network); 10 Jun 2006 00:16:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2006 00:16:23 -0000 X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:48765] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id C8/64-30619-65F0A844 for ; Fri, 09 Jun 2006 20:16:22 -0400 Received: from baumbart.mbo (dslb-084-063-027-200.pools.arcor-ip.net [84.63.27.200]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 8040535C1C1; Sat, 10 Jun 2006 02:16:18 +0200 (CEST) Date: Sat, 10 Jun 2006 02:16:33 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1905498448.20060610021633@marcus-boerger.de> To: Hannes Magnusson Cc: Dmitry Stogov , Andi Gutmans , In-Reply-To: <7f3ed2c30606090806w36158503h12ede2ae8bcf21e7@mail.gmail.com> References: <000001c68bd3$667bfd80$6e02a8c0@thinkpad> <7f3ed2c30606090806w36158503h12ede2ae8bcf21e7@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] PHP6 broken From: helly@php.net (Marcus Boerger) Hello Hannes, the patch looks good and solves the issues as far as i can tell. We might want to make the abstract part an interface but we'll see. Just commit for now. best regards marcus Friday, June 9, 2006, 5:06:02 PM, you wrote: > On 6/9/06, Dmitry Stogov wrote: >> Hi Marcus, >> >> Could you please fix PHP6 build. >> You broke it day or two ago :( > Yeah, sorry about that, was my fault (it broke 5_2 to). > Actually, this bug has been there for a while, but the engine didn't > catch it since it had no idea which parameters the methods had. > I have a patch ready, which moves all methods from ReflectionFunction > into ReflectionFunctionAbstract (except from export, invoke & > invokeArgs), http://php.is/bugs/reflection/reflections.patch.txt, just > need someone to review it before I commit it. > -Hannes >> >> After your modifications of ext/reflection PHP always emits error messages >> about method incompatibilities. >> >> I am not sure if static methods must be checked for compatibility (I mean >> ReflectionMethod::export()), but ReflectionMethod::invoke() is not static. >> >> Thanks. Dmitry. >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> Best regards, Marcus