I had another look at Joshua's upload progress patch:
I seem to remember there being some valid reason for not adding this
patch, but looking over the code, it doesn't jump out at me. It seems
safe enough unless I am missing a subtle TSRM issue. Anybody remember
what the problem was?
-Rasmus
Rasmus Lerdorf wrote:
I had another look at Joshua's upload progress patch:
I seem to remember there being some valid reason for not adding this
patch, but looking over the code, it doesn't jump out at me. It seems
safe enough unless I am missing a subtle TSRM issue. Anybody remember
what the problem was?
There is variation here:
http://www.zend.com/zend/week/pat/pat23.txt
Quite similar. The one change I would make to both would be to put the
temp filename in the callback call so the extension on the other end has
a chance to keep track of which upload caused the callback to trigger in
a threaded environment with concurrent uploads.
-Rasmus
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Rasmus,
do you think you can take another look at the patch and the extension so
maybe it can be included into PHP?
thanks,
-
- Markus
Rasmus Lerdorf wrote:
Rasmus Lerdorf wrote:
I had another look at Joshua's upload progress patch:
I seem to remember there being some valid reason for not adding this
patch, but looking over the code, it doesn't jump out at me. It seems
safe enough unless I am missing a subtle TSRM issue. Anybody remember
what the problem was?There is variation here:
http://www.zend.com/zend/week/pat/pat23.txt
Quite similar. The one change I would make to both would be to put the
temp filename in the callback call so the extension on the other end has
a chance to keep track of which upload caused the callback to trigger in
a threaded environment with concurrent uploads.-Rasmus
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFEl7nF1nS0RcInK9ARAuF+AJ939ygS2BM9htXzOnlhR4frP0pHiwCdHkS+
K+aeMpVnsoNxtzfC1ZhCvzI=
=zcmu
-----END PGP SIGNATURE