Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:23033 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34511 invoked by uid 1010); 29 Apr 2006 14:54:11 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 34490 invoked from network); 29 Apr 2006 14:54:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Apr 2006 14:54:11 -0000 X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 204.11.219.139 lerdorf.com Linux 2.5 (sometimes 2.4) (4) Received: from ([204.11.219.139:49364] helo=lerdorf.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 67/21-18514-11E73544 for ; Sat, 29 Apr 2006 10:54:09 -0400 Received: from [192.168.200.106] (c-24-6-5-134.hsd1.ca.comcast.net [24.6.5.134]) (authenticated bits=0) by lerdorf.com (8.13.6/8.13.6/Debian-1) with ESMTP id k3TEs5YQ007227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 29 Apr 2006 07:54:05 -0700 Message-ID: <44537E0D.7060309@lerdorf.com> Date: Sat, 29 Apr 2006 07:54:05 -0700 User-Agent: Thunderbird 3.0a1 (Macintosh/20060414) MIME-Version: 1.0 To: internals References: <445377F1.5000703@lerdorf.com> In-Reply-To: <445377F1.5000703@lerdorf.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Joshua's upload progress patch From: rasmus@lerdorf.com (Rasmus Lerdorf) Rasmus Lerdorf wrote: > I had another look at Joshua's upload progress patch: > > http://pdoru.from.ro/upload-progress-meter/upload-progress-meter-v4.1/php-patch/patch.upload-progress-callback-v4.1-for-php5.0.3.txt > > > I seem to remember there being some valid reason for not adding this > patch, but looking over the code, it doesn't jump out at me. It seems > safe enough unless I am missing a subtle TSRM issue. Anybody remember > what the problem was? There is variation here: http://www.zend.com/zend/week/pat/pat23.txt Quite similar. The one change I would make to both would be to put the temp filename in the callback call so the extension on the other end has a chance to keep track of which upload caused the callback to trigger in a threaded environment with concurrent uploads. -Rasmus