Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:24158 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83360 invoked by uid 1010); 20 Jun 2006 09:03:05 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 83344 invoked from network); 20 Jun 2006 09:03:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jun 2006 09:03:05 -0000 X-PHP-List-Original-Sender: markus@fischer.name X-Host-Fingerprint: 213.46.255.14 viefep14-int.chello.at Solaris 8 (1) Received: from ([213.46.255.14:58002] helo=viefep11-int.chello.at) by pb1.pair.com (ecelerity 2.1.1.3 r(11751M)) with ESMTP id 1D/E5-25433-5C9B7944 for ; Tue, 20 Jun 2006 05:03:02 -0400 Received: from genuine ([80.108.128.16]) by viefep11-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20060620090307.PTCE14766.viefep11-int.chello.at@genuine>; Tue, 20 Jun 2006 11:03:07 +0200 Received: from 62-99-200-226.sdsl-line.inode.at ([62.99.200.226] helo=[192.168.100.164]) by genuine with esmtpa (Exim 4.50) id 1Fsc6I-0000Pe-2m; Tue, 20 Jun 2006 11:00:50 +0200 Message-ID: <4497B9C5.3010000@fischer.name> Date: Tue, 20 Jun 2006 11:03:01 +0200 User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: Rasmus Lerdorf CC: internals References: <445377F1.5000703@lerdorf.com> <44537E0D.7060309@lerdorf.com> In-Reply-To: <44537E0D.7060309@lerdorf.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0 X-Spam-Level: / X-Spam-Report: Spam detection software, running on the system "genuine", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Rasmus, do you think you can take another look at the patch and the extension so maybe it can be included into PHP? [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- Subject: Re: [PHP-DEV] Joshua's upload progress patch From: markus@fischer.name (Markus Fischer) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Rasmus, do you think you can take another look at the patch and the extension so maybe it can be included into PHP? thanks, - - Markus Rasmus Lerdorf wrote: > Rasmus Lerdorf wrote: >> I had another look at Joshua's upload progress patch: >> >> http://pdoru.from.ro/upload-progress-meter/upload-progress-meter-v4.1/php-patch/patch.upload-progress-callback-v4.1-for-php5.0.3.txt >> >> >> I seem to remember there being some valid reason for not adding this >> patch, but looking over the code, it doesn't jump out at me. It seems >> safe enough unless I am missing a subtle TSRM issue. Anybody remember >> what the problem was? > > There is variation here: > > http://www.zend.com/zend/week/pat/pat23.txt > > Quite similar. The one change I would make to both would be to put the > temp filename in the callback call so the extension on the other end has > a chance to keep track of which upload caused the callback to trigger in > a threaded environment with concurrent uploads. > > -Rasmus > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFEl7nF1nS0RcInK9ARAuF+AJ939ygS2BM9htXzOnlhR4frP0pHiwCdHkS+ K+aeMpVnsoNxtzfC1ZhCvzI= =zcmu -----END PGP SIGNATURE-----