Addition of line numbering to phps
This is a rather simple addition and will be benificial to all who use phps
for debugging and/or displaying code. Its a simple diff to zend_highlight.c
Patches have been written and languish simply awaiting inclusion in HEAD
Can we have a show of hands of those who would like this?
5.1 patch can be viewed here:
http://svn.schlueters.de/phpatches/PHP_5_1/zend_highlight_ol.diff
Any real reason this cannot be included?
Kind regards
kevin
--
"Democracy is two wolves and a lamb voting on what to have for lunch.
Liberty is a well-armed lamb contesting the vote."
I'd consider it for PHP6, but not for PHP5.1 at least not at this time.
Ilia
Kevin Waterson wrote:
Addition of line numbering to phps
This is a rather simple addition and will be benificial to all who use phps
for debugging and/or displaying code. Its a simple diff to zend_highlight.cPatches have been written and languish simply awaiting inclusion in HEAD
Can we have a show of hands of those who would like this?
5.1 patch can be viewed here:
http://svn.schlueters.de/phpatches/PHP_5_1/zend_highlight_ol.diffAny real reason this cannot be included?
Kind regards
kevin
Hi Ilia et al.,
the patch is older than PHP 6 and back then there was nobody interested in
committing it so it wasn't brought to HEAD, yet. But I'll do that if the
patch itself is being accepted.
johannes
I'd consider it for PHP6, but not for PHP5.1 at least not at this time.
Ilia
Kevin Waterson wrote:
Addition of line numbering to phps
This is a rather simple addition and will be benificial to all who use
phps for debugging and/or displaying code. Its a simple diff to
zend_highlight.cPatches have been written and languish simply awaiting inclusion in HEAD
Can we have a show of hands of those who would like this?
5.1 patch can be viewed here:
http://svn.schlueters.de/phpatches/PHP_5_1/zend_highlight_ol.diffAny real reason this cannot be included?
Kind regards
kevin
I'd consider it for PHP6, but not for PHP5.1 at least not at this time.
I'm definitively for having it in php6. For 5.x, if there is a 5.2,
then it could be in too.
--Pierre
Ilia Alshanetsky wrote:
I'd consider it for PHP6, but not for PHP5.1 at least not at this time.
what exactly is the big deal with adding a new optional parameter?
i dont really see the huge impact that should push this feature back to
the next major php version. its something that could go into any minor
version.
regards,
Lukas
Lukas Smith wrote:
Ilia Alshanetsky wrote:
I'd consider it for PHP6, but not for PHP5.1 at least not at this time.
what exactly is the big deal with adding a new optional parameter?
i dont really see the huge impact that should push this feature back to
the next major php version. its something that could go into any minor
version.
maybe i should clarify that i am only concered about the
highlight_file(9 and highlight_string() functions. i dont even think we
should add linenumbers to .phps.
regards,
Lukas
Kevin Waterson schrieb:
Addition of line numbering to phps
This is a rather simple addition and will be benificial to all who use phps
for debugging and/or displaying code. Its a simple diff to zend_highlight.c
Hello Kevin,
I haven't tested this - but if phps output is numbered, it will be
completely cluttered and you can't copy-paste anymore. Exactly when
displaying code so that people can adapt it that's a quite bad idea
then imho. Rather add another extension and leave .phps like it is.
Greetings,
Florian
arg, I'm wrong - ignore me please
How about including the patch, and having a php.ini option to
enable/disable the line numbering.
Kevin Waterson wrote:
Addition of line numbering to phps
This is a rather simple addition and will be benificial to all who use phps
for debugging and/or displaying code. Its a simple diff to zend_highlight.cPatches have been written and languish simply awaiting inclusion in HEAD
Can we have a show of hands of those who would like this?
5.1 patch can be viewed here:
http://svn.schlueters.de/phpatches/PHP_5_1/zend_highlight_ol.diffAny real reason this cannot be included?
Kind regards
kevin
--
aizat faiz: sleep to the power of z. -_-;;^zzz
strange symphonies - http://aizatto.com/
How about including the patch, and having a php.ini option to enable/disable
the line numbering.
NO more ini settings please... and definitely not for something trivial
as this.
Derick
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
This one time, at band camp, Aizat Faiz aizat.faiz@gmail.com wrote:
How about including the patch, and having a php.ini option to
enable/disable the line numbering.
I dont think this is a good option, perhaps some other trigger
file.phps?numbers or something
Kevin
--
"Democracy is two wolves and a lamb voting on what to have for lunch.
Liberty is a well-armed lamb contesting the vote."
That other time, at band camp, Kevin Waterson wrote:
This one time, at band camp, Aizat Faiz aizat.faiz@gmail.com wrote:
How about including the patch, and having a php.ini option to
enable/disable the line numbering.I dont think this is a good option, perhaps some other trigger
file.phps?numbers or something
But there'd better be an ini option to disable that, and an ini option
to control whether line numbering starts at zero or one, and an ini
option to disable the ini options. Everyone loves ini options :)
Patches have been written and languish simply awaiting inclusion in HEAD
Johannes' method (<ol><li>...</li>...</ol>) doesn't copy & paste well in
FireFox 1.5 -- you might consider this a FF problem, but in any case,
line numbers are pasted, so this is really a pain for sharing code.
Until a good method is found (if there is one), I say leave the patch
out -- although, FWIW, I would like to see line numbers if there's a
way to make it work well (avoid horizontal scrolling, paste without
numbers).
S