Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:22455
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: internals@lists.php.net
Date: Wed, 15 Mar 2006 15:52:35 +0100
User-Agent: KMail/1.9.1
Cc: Ilia Alshanetsky <ilia@prohost.org>,
	Kevin Waterson <kevin@oceania.net>
References: <20060316010210.5f76c9f5.kevin@oceania.net> <441828B4.4030007@prohost.org>
In-Reply-To: <441828B4.4030007@prohost.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200603151552.36965.johannes@php.net>
Subject: Re: [PHP-DEV] phps line numbering
From: johannes@php.net (Johannes Schlueter)

Hi Ilia et al.,

the patch is older than PHP 6 and back then there was nobody interested in 
committing it so it wasn't brought to HEAD, yet. But I'll do that if the 
patch itself is being accepted.

johannes

On Wednesday 15 March 2006 15:46, Ilia Alshanetsky wrote:
> I'd consider it for PHP6, but not for PHP5.1 at least not at this time.
>
> Ilia
>
> Kevin Waterson wrote:
> > Addition of line numbering to phps
> > This is a rather simple addition and will be benificial to all who use
> > phps for debugging and/or displaying code. Its a simple diff to
> > zend_highlight.c
> >
> > Patches have been written and languish simply awaiting inclusion in HEAD
> >
> > Can we have a show of hands of those who would like this?
> > 5.1 patch can be viewed here:
> > http://svn.schlueters.de/phpatches/PHP_5_1/zend_highlight_ol.diff
> >
> > Any real reason this cannot be included?
> >
> > Kind regards
> > kevin