Hi,
any objections against fixing our cookie system to also read version 1
cookies correctly?
I want to apply the following patch to all 3 branches:
http://www.suspekt.org/patches/php_variables.c.diff
Stefan
--
Stefan Esser sesser@php.net
Hardened-PHP Project http://www.hardened-php.net/
GPG-Key gpg --keyserver pgp.mit.edu --recv-key 0x15ABDA78
Key fingerprint 7806 58C8 CFA8 CE4A 1C2C 57DD 4AE1 795E 15AB DA78
-1 on adding this patch to the stable branches.
Edin
----- Original Message -----
From: "Stefan Esser" sesser@php.net
To: "PHP internals" internals@lists.php.net
Sent: Monday, April 25, 2005 6:06 PM
Subject: [PHP-DEV] [PATCH] rfc2965 version 1 cookie support
Hi,
any objections against fixing our cookie system to also read version 1
cookies correctly?I want to apply the following patch to all 3 branches:
http://www.suspekt.org/patches/php_variables.c.diff
Stefan
--
Stefan Esser
sesser@php.net
Hardened-PHP Project
http://www.hardened-php.net/GPG-Key gpg --keyserver pgp.mit.edu --recv-key 0x15ABDA78
Key fingerprint 7806 58C8 CFA8 CE4A 1C2C 57DD 4AE1 795E 15AB DA78
Stefan Esser wrote:
Hi,
any objections against fixing our cookie system to also read version 1
cookies correctly?I want to apply the following patch to all 3 branches:
What is the status of this? I have been offline for a while and am
trying to catch up. My view is that we shouldn't be messing with cookie
parsing in the 4.3 tree at all, but having full version 1 support in
PHP5, or I guess PHP5.1 at this point is a good idea.
So I would like to see Jani's patch to 4.3 reverted and this committed
to HEAD.
-Rasmus
Stefan Esser wrote:
Hi,
any objections against fixing our cookie system to also read version 1
cookies correctly?I want to apply the following patch to all 3 branches:
What is the status of this? I have been offline for a while and am trying to
catch up. My view is that we shouldn't be messing with cookie parsing in the
4.3 tree at all, but having full version 1 support in PHP5, or I guess PHP5.1
at this point is a good idea.
IMO, only to HEAD.
So I would like to see Jani's patch to 4.3 reverted and this committed to
HEAD.
You didn't catch up enough, I reverted it already. :)
--Jani