Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:16130 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97410 invoked by uid 1010); 29 Apr 2005 01:21:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 97395 invoked from network); 29 Apr 2005 01:21:41 -0000 Received: from unknown (HELO pb1.pair.com) (127.0.0.1) by localhost with SMTP; 29 Apr 2005 01:21:41 -0000 X-Host-Fingerprint: 204.11.219.139 lerdorf.com Linux 2.4/2.6 Received: from ([204.11.219.139:37665] helo=colo.lerdorf.com) by pb1.pair.com (ecelerity 1.2.12rc1 r(5476:5477)) with SMTP id 03/E3-20173-32C81724 for ; Thu, 28 Apr 2005 21:21:39 -0400 Received: from [192.168.2.106] (c-24-6-1-160.hsd1.ca.comcast.net [24.6.1.160]) (authenticated bits=0) by colo.lerdorf.com (8.13.4/8.13.4/Debian-1) with ESMTP id j3T0sEJg018099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 28 Apr 2005 17:54:15 -0700 Message-ID: <427185BB.8040304@lerdorf.com> Date: Thu, 28 Apr 2005 17:54:19 -0700 User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Stefan Esser CC: PHP internals References: <426D157D.5070109@php.net> In-Reply-To: <426D157D.5070109@php.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] rfc2965 version 1 cookie support From: rasmus@lerdorf.com (Rasmus Lerdorf) Stefan Esser wrote: > Hi, > > any objections against fixing our cookie system to also read version 1 > cookies correctly? > > I want to apply the following patch to all 3 branches: > > http://www.suspekt.org/patches/php_variables.c.diff What is the status of this? I have been offline for a while and am trying to catch up. My view is that we shouldn't be messing with cookie parsing in the 4.3 tree at all, but having full version 1 support in PHP5, or I guess PHP5.1 at this point is a good idea. So I would like to see Jani's patch to 4.3 reverted and this committed to HEAD. -Rasmus