Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:16131 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39420 invoked by uid 1010); 29 Apr 2005 01:54:22 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 39391 invoked from network); 29 Apr 2005 01:54:21 -0000 Received: from unknown (HELO pb1.pair.com) (127.0.0.1) by localhost with SMTP; 29 Apr 2005 01:54:21 -0000 X-Host-Fingerprint: 195.197.172.115 gw01.mail.saunalahti.fi Linux 2.4/2.6 Received: from ([195.197.172.115:34079] helo=gw01.mail.saunalahti.fi) by pb1.pair.com (ecelerity 1.2.12rc1 r(5476:5477)) with SMTP id BB/D5-20173-CC391724 for ; Thu, 28 Apr 2005 21:54:20 -0400 Received: from nest.netphobia.fi (YZCLXVIII.dsl.saunalahti.fi [85.76.34.69]) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id 6F295DF5A9; Fri, 29 Apr 2005 04:53:53 +0300 (EEST) Received: from nest.netphobia.fi (nest.netphobia.fi [127.0.0.1]) by nest.netphobia.fi (8.13.4/8.13.1) with ESMTP id j3T1rrb9019828; Fri, 29 Apr 2005 04:53:53 +0300 Received: from localhost (jani@localhost) by nest.netphobia.fi (8.13.4/8.13.1/Submit) with ESMTP id j3T1rqBQ019825; Fri, 29 Apr 2005 04:53:53 +0300 X-Authentication-Warning: nest.netphobia.fi: jani owned process doing -bs Date: Fri, 29 Apr 2005 04:53:52 +0300 (EEST) Reply-To: Jani Taskinen To: Rasmus Lerdorf Cc: Stefan Esser , PHP internals In-Reply-To: <427185BB.8040304@lerdorf.com> Message-ID: References: <426D157D.5070109@php.net> <427185BB.8040304@lerdorf.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [PHP-DEV] [PATCH] rfc2965 version 1 cookie support From: sniper@iki.fi (Jani Taskinen) On Thu, 28 Apr 2005, Rasmus Lerdorf wrote: > Stefan Esser wrote: >> Hi, >> >> any objections against fixing our cookie system to also read version 1 >> cookies correctly? >> >> I want to apply the following patch to all 3 branches: >> >> http://www.suspekt.org/patches/php_variables.c.diff > > What is the status of this? I have been offline for a while and am trying to > catch up. My view is that we shouldn't be messing with cookie parsing in the > 4.3 tree at all, but having full version 1 support in PHP5, or I guess PHP5.1 > at this point is a good idea. IMO, only to HEAD. > So I would like to see Jani's patch to 4.3 reverted and this committed to > HEAD. You didn't catch up enough, I reverted it already. :) --Jani