I took a look at the code and I can't see why it wouldn't work. I lost my
VC++ environment recently because my machine died. Maybe someone else can
try and see what's going on until I rebuild mine.

Andi

At 08:56 PM 2/16/2005 -0800, Frank M. Kromann wrote:

Hi Andi,

Here is the diff I send to Markus earlier today. Not sure why this works
and the original does'nt.

cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite)
Index: sqlite.c

RCS file: /repository/php-src/ext/sqlite/sqlite.c,v
retrieving revision 1.157
diff -u -w -b -r1.157 sqlite.c
--- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157
+++ sqlite.c 17 Feb 2005 00:47:36 -0000
@@ -1015,7 +1015,9 @@
sqlite_ce_ub_query->iterator_funcs.funcs =
&sqlite_ub_query_iterator_funcs;

#ifdef HAVE_SPL

• zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
  spl_ce_Countable);

• zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
• zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable);
  +// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
  spl_ce_Countable);
  #else
  zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
  #endif

• Frank

Can you send the diff of that commit?

At 16:35 16/02/2005 -0800, Frank M. Kromann wrote:

Hello Everyone,

I have narowed it down to the last commit to ext\sqlite.c. This seams
to
be the first time zend_class_implements is called with two interfaces.

• Frank

Hello Everyone,

The Win32 builds (mine and those from snaps). It crashes in
tsrm_shutdown(). I'm trying to figure out what cased this, and so
far I
know it happned between Feb. 10 and now.

• Frank

I see Marcus found the problem. Definitely required a compiler to find this
problem :)

At 12:25 PM 2/17/2005 -0800, Andi Gutmans wrote:

I took a look at the code and I can't see why it wouldn't work. I lost my
VC++ environment recently because my machine died. Maybe someone else can
try and see what's going on until I rebuild mine.

Andi

At 08:56 PM 2/16/2005 -0800, Frank M. Kromann wrote:

Hi Andi,

Here is the diff I send to Markus earlier today. Not sure why this works
and the original does'nt.

cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite)
Index: sqlite.c

RCS file: /repository/php-src/ext/sqlite/sqlite.c,v
retrieving revision 1.157
diff -u -w -b -r1.157 sqlite.c
--- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157
+++ sqlite.c 17 Feb 2005 00:47:36 -0000
@@ -1015,7 +1015,9 @@
sqlite_ce_ub_query->iterator_funcs.funcs =
&sqlite_ub_query_iterator_funcs;

#ifdef HAVE_SPL

• zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
  spl_ce_Countable);

• zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
• zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable);
  +// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
  spl_ce_Countable);
  #else
  zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
  #endif

• Frank

Can you send the diff of that commit?

At 16:35 16/02/2005 -0800, Frank M. Kromann wrote:

Hello Everyone,

I have narowed it down to the last commit to ext\sqlite.c. This seams
to
be the first time zend_class_implements is called with two interfaces.

• Frank

Hello Everyone,

The Win32 builds (mine and those from snaps). It crashes in
tsrm_shutdown(). I'm trying to figure out what cased this, and so
far I
know it happned between Feb. 10 and now.

• Frank

Hello Frank,

the problem turned out to be a possible memory reallocation/size
evaluation violation. After switching some times between *nix and
windows i think i have solved the issue completeley now.

regards
marcus

Thursday, February 17, 2005, 5:56:50 AM, you wrote:

Hi Andi,

Here is the diff I send to Markus earlier today. Not sure why this works
and the original does'nt.

cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite)
Index: sqlite.c

RCS file: /repository/php-src/ext/sqlite/sqlite.c,v
retrieving revision 1.157
diff -u -w -b -r1.157 sqlite.c
--- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157
+++ sqlite.c 17 Feb 2005 00:47:36 -0000
@@ -1015,7 +1015,9 @@
sqlite_ce_ub_query->iterator_funcs.funcs =
&sqlite_ub_query_iterator_funcs;

#ifdef HAVE_SPL

• zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
  spl_ce_Countable);

• zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
• zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable);
  +// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator,
  spl_ce_Countable);
  #else
  zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator);
  #endif

• Frank

Can you send the diff of that commit?

At 16:35 16/02/2005 -0800, Frank M. Kromann wrote:

Hello Everyone,

I have narowed it down to the last commit to ext\sqlite.c. This seams
to
be the first time zend_class_implements is called with two interfaces.

• Frank

Hello Everyone,

The Win32 builds (mine and those from snaps). It crashes in
tsrm_shutdown(). I'm trying to figure out what cased this, and so
far I
know it happned between Feb. 10 and now.

• Frank

--

--

--
Best regards,
Marcus mailto:helly@php.net