Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15069 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92886 invoked by uid 1010); 17 Feb 2005 21:07:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 92857 invoked from network); 17 Feb 2005 21:07:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Feb 2005 21:07:30 -0000 X-Host-Fingerprint: 83.97.50.139 jan.prima.de FreeBSD 4.6-4.9 Received: from ([83.97.50.139:3250] helo=jan.prima.de) by pb1.pair.com (ecelerity 1.2 (r4437)) with SMTP id 99/39-39535-19705124 for ; Thu, 17 Feb 2005 16:07:30 -0500 Received: from BAUMBART (pD95F8533.dip.t-dialin.net [::ffff:217.95.133.51]) (IDENT: HydraIRC, AUTH: LOGIN tobi) by jan.prima.de with esmtp; Thu, 17 Feb 2005 21:07:26 +0000 Date: Thu, 17 Feb 2005 22:07:36 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1957052826.20050217220736@marcus-boerger.de> To: "Frank M. Kromann" CC: Andi Gutmans , internals@lists.php.net In-Reply-To: <11086162102480000@9866357972520000.9866341568840000> References: <11086162102480000@9866357972520000.9866341568840000> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Win32 builds are broken From: helly@php.net (Marcus Boerger) Hello Frank, the problem turned out to be a possible memory reallocation/size evaluation violation. After switching some times between *nix and windows i think i have solved the issue completeley now. regards marcus Thursday, February 17, 2005, 5:56:50 AM, you wrote: > Hi Andi, > Here is the diff I send to Markus earlier today. Not sure why this works > and the original does'nt. > cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite\) > Index: sqlite.c > =================================================================== > RCS file: /repository/php-src/ext/sqlite/sqlite.c,v > retrieving revision 1.157 > diff -u -w -b -r1.157 sqlite.c > --- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157 > +++ sqlite.c 17 Feb 2005 00:47:36 -0000 > @@ -1015,7 +1015,9 @@ > sqlite_ce_ub_query->iterator_funcs.funcs = > &sqlite_ub_query_iterator_funcs; > #ifdef HAVE_SPL > - zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator, > spl_ce_Countable); > + zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator); > + zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable); > +// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator, > spl_ce_Countable); > #else > zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator); > #endif > - Frank >> Can you send the diff of that commit? >> >> At 16:35 16/02/2005 -0800, Frank M. Kromann wrote: >> >Hello Everyone, >> > >> >I have narowed it down to the last commit to ext\sqlite.c. This seams > to >> >be the first time zend_class_implements is called with two interfaces. >> > >> >- Frank >> > >> > > Hello Everyone, >> > > >> > > The Win32 builds (mine and those from snaps). It crashes in >> > > tsrm_shutdown(). I'm trying to figure out what cased this, and so > far I >> > > know it happned between Feb. 10 and now. >> > > >> > > - Frank >> > > >> > > -- >> > > PHP Internals - PHP Runtime Development Mailing List >> > > To unsubscribe, visit: http://www.php.net/unsub.php >> > > >> > >> >-- >> >PHP Internals - PHP Runtime Development Mailing List >> >To unsubscribe, visit: http://www.php.net/unsub.php >> -- Best regards, Marcus mailto:helly@php.net