Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15064 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 29555 invoked by uid 1010); 17 Feb 2005 20:25:11 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 29540 invoked from network); 17 Feb 2005 20:25:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Feb 2005 20:25:11 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:45502] helo=mail.zend.com) by pb1.pair.com (ecelerity 1.2 (r4437)) with SMTP id 5B/46-39535-6ADF4124 for ; Thu, 17 Feb 2005 15:25:11 -0500 Received: (qmail 2790 invoked from network); 17 Feb 2005 20:25:03 -0000 Received: from localhost (HELO DORON-LAPTOP.zend.com) (127.0.0.1) by localhost with SMTP; 17 Feb 2005 20:25:03 -0000 Message-ID: <5.1.0.14.2.20050217122419.020782b8@localhost> X-Sender: andi@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Thu, 17 Feb 2005 12:25:00 -0800 To: "Frank M. Kromann" Cc: In-Reply-To: <11086162102480000@9866357972520000.9866341568840000> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Win32 builds are broken From: andi@zend.com (Andi Gutmans) References: <11086162102480000@9866357972520000.9866341568840000> I took a look at the code and I can't see why it wouldn't work. I lost my VC++ environment recently because my machine died. Maybe someone else can try and see what's going on until I rebuild mine. Andi At 08:56 PM 2/16/2005 -0800, Frank M. Kromann wrote: >Hi Andi, > >Here is the diff I send to Markus earlier today. Not sure why this works >and the original does'nt. > >cvs -z9 diff -u -wb sqlite.c (in directory C:\PHP\php5\ext\sqlite\) >Index: sqlite.c >=================================================================== >RCS file: /repository/php-src/ext/sqlite/sqlite.c,v >retrieving revision 1.157 >diff -u -w -b -r1.157 sqlite.c >--- sqlite.c 15 Feb 2005 21:09:42 -0000 1.157 >+++ sqlite.c 17 Feb 2005 00:47:36 -0000 >@@ -1015,7 +1015,9 @@ >sqlite_ce_ub_query->iterator_funcs.funcs = >&sqlite_ub_query_iterator_funcs; > >#ifdef HAVE_SPL >- zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator, >spl_ce_Countable); >+ zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator); >+ zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, spl_ce_Countable); >+// zend_class_implements(sqlite_ce_query TSRMLS_CC, 2, zend_ce_iterator, >spl_ce_Countable); >#else >zend_class_implements(sqlite_ce_query TSRMLS_CC, 1, zend_ce_iterator); >#endif > >- Frank > > > > Can you send the diff of that commit? > > > > At 16:35 16/02/2005 -0800, Frank M. Kromann wrote: > > >Hello Everyone, > > > > > >I have narowed it down to the last commit to ext\sqlite.c. This seams >to > > >be the first time zend_class_implements is called with two interfaces. > > > > > >- Frank > > > > > > > Hello Everyone, > > > > > > > > The Win32 builds (mine and those from snaps). It crashes in > > > > tsrm_shutdown(). I'm trying to figure out what cased this, and so >far I > > > > know it happned between Feb. 10 and now. > > > > > > > > - Frank > > > > > > > > -- > > > > PHP Internals - PHP Runtime Development Mailing List > > > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > > > > >-- > > >PHP Internals - PHP Runtime Development Mailing List > > >To unsubscribe, visit: http://www.php.net/unsub.php > >