When safe_mode is set to 'on', popen()
uses char buf[1024] to build argument list. This is not good, as it truncates command line without notice.
This is NOT operating system limit - as noted on bugreport, but PHP bug.
If anybody cares, here is fix for this bug under 4.3.9:
http://leya.mindnever.org/~mr_w/php-popen.patch.gz
PS, didn't have time to look at PHP 5 yet, but I suppose this fix could
work also with minor tweaks.
--
Vladimir Zidar, Programmer
MindNever Foodstuff TRDG.
Head Office Branch
Tel: +381-63-550161, +385-98-9574261
http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org
This patch makes sense to me. Anyone have a problem with it?
Andi
At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote:
When safe_mode is set to 'on',
popen()
uses char buf[1024] to build
argument list. This is not good, as it truncates command line without notice.
This is NOT operating system limit - as noted on bugreport, but PHP bug.If anybody cares, here is fix for this bug under 4.3.9:
http://leya.mindnever.org/~mr_w/php-popen.patch.gz
PS, didn't have time to look at PHP 5 yet, but I suppose this fix could
work also with minor tweaks.--
Vladimir Zidar, ProgrammerMindNever Foodstuff TRDG.
Head Office BranchTel: +381-63-550161, +385-98-9574261
http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org
I'd feel slightly happier if it used spprintf() instead of manually
calculating the buffer length, but otherwise I'm okay with it.
--Wez.
This patch makes sense to me. Anyone have a problem with it?
Andi
At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote:
When safe_mode is set to 'on',
popen()
uses char buf[1024] to build
argument list. This is not good, as it truncates command line without notice.
This is NOT operating system limit - as noted on bugreport, but PHP bug.If anybody cares, here is fix for this bug under 4.3.9:
http://leya.mindnever.org/~mr_w/php-popen.patch.gz
PS, didn't have time to look at PHP 5 yet, but I suppose this fix could
work also with minor tweaks.--
Vladimir Zidar, ProgrammerMindNever Foodstuff TRDG.
Head Office BranchTel: +381-63-550161, +385-98-9574261
http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org
I didn't know that such function exist. I can change my patch, and
everybody should feel better.. ok ?
I'd feel slightly happier if it used spprintf() instead of manually
calculating the buffer length, but otherwise I'm okay with it.--Wez.
This patch makes sense to me. Anyone have a problem with it?
Andi
At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote:
When safe_mode is set to 'on',
popen()
uses char buf[1024] to build
argument list. This is not good, as it truncates command line without notice.
This is NOT operating system limit - as noted on bugreport, but PHP bug.If anybody cares, here is fix for this bug under 4.3.9:
http://leya.mindnever.org/~mr_w/php-popen.patch.gz
PS, didn't have time to look at PHP 5 yet, but I suppose this fix could
work also with minor tweaks.--
Vladimir Zidar, ProgrammerMindNever Foodstuff TRDG.
Head Office BranchTel: +381-63-550161, +385-98-9574261
http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org--
--
--
Vladimir Zidar, Programmer
MindNever Foodstuff TRDG.
Head Office Branch
Tel: +381-63-550161, +385-98-9574261
http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org
Here is version that uses spprintf()
http://leya.mindnever.org/~mr_w/php-popen2.patch.gz
I didn't know that such function exist. I can change my patch, and
everybody should feel better.. ok ?I'd feel slightly happier if it used spprintf() instead of manually
calculating the buffer length, but otherwise I'm okay with it.