Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13570 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 30500 invoked by uid 1010); 27 Oct 2004 17:23:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 30188 invoked from network); 27 Oct 2004 17:23:45 -0000 Received: from unknown (HELO mproxy.gmail.com) (216.239.56.244) by pb1.pair.com with SMTP; 27 Oct 2004 17:23:45 -0000 Received: by mproxy.gmail.com with SMTP id w67so126343cwb for ; Wed, 27 Oct 2004 10:23:44 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=CxxM34z9eUZ3bgz2UxK+cQL8fbwTKlT2AY85wQ0fS79FQoZ+2kVtGIUlXaD66bcHHfPYb+MAKSzkQqL5zZ4RI5wnyW4yWWYrDQAIeH8PFNUcZeBNq42avJH5lqb8RjBWpGz9MTr+8WtMc657BxHBZPeTiA6FXREi2dUxq2rEysc= Received: by 10.11.119.44 with SMTP id r44mr305253cwc; Wed, 27 Oct 2004 10:23:44 -0700 (PDT) Received: by 10.11.117.13 with HTTP; Wed, 27 Oct 2004 10:23:44 -0700 (PDT) Message-ID: <4e89b426041027102347601f19@mail.gmail.com> Date: Wed, 27 Oct 2004 18:23:44 +0100 Reply-To: Wez Furlong To: Andi Gutmans Cc: Vladimir Zidar , internals@lists.php.net In-Reply-To: <5.1.0.14.2.20041027095139.02e55690@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <1098879262.4898.34.camel@mravojed> <5.1.0.14.2.20041027095139.02e55690@localhost> Subject: Re: [PHP-DEV] [PATCH] Bug fix for #29770, but for PHP 4.3.9 From: kingwez@gmail.com (Wez Furlong) I'd feel slightly happier if it used spprintf() instead of manually calculating the buffer length, but otherwise I'm okay with it. --Wez. On Wed, 27 Oct 2004 09:51:52 -0700, Andi Gutmans wrote: > This patch makes sense to me. Anyone have a problem with it? > > Andi > > > > At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote: > > When safe_mode is set to 'on', popen() uses char buf[1024] to build > > argument list. This is not good, as it truncates command line without notice. > > This is NOT operating system limit - as noted on bugreport, but PHP bug. > > > > If anybody cares, here is fix for this bug under 4.3.9: > > > > http://leya.mindnever.org/~mr_w/php-popen.patch.gz > > > > PS, didn't have time to look at PHP 5 yet, but I suppose this fix could > >work also with minor tweaks. > > > > > >-- > >Vladimir Zidar, Programmer > > > >MindNever Foodstuff TRDG. > >Head Office Branch > > > >Tel: +381-63-550161, +385-98-9574261 > >http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org > > > >-- > >PHP Internals - PHP Runtime Development Mailing List > >To unsubscribe, visit: http://www.php.net/unsub.php > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >