Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:13572 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62599 invoked by uid 1010); 27 Oct 2004 17:30:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 62536 invoked from network); 27 Oct 2004 17:30:30 -0000 Received: from unknown (HELO marvin.mindnever.org) (80.74.160.83) by pb1.pair.com with SMTP; 27 Oct 2004 17:30:30 -0000 Received: (qmail 29986 invoked by uid 509); 27 Oct 2004 17:20:03 -0000 Received: from bunuel-cpe-185-bgd.sbb.co.yu (HELO mravojed.office.kom) (82.117.196.185) by marvin.mindnever.org with SMTP; 27 Oct 2004 17:19:58 -0000 To: Wez Furlong Cc: Andi Gutmans , internals@lists.php.net In-Reply-To: <4e89b426041027102347601f19@mail.gmail.com> References: <1098879262.4898.34.camel@mravojed> <5.1.0.14.2.20041027095139.02e55690@localhost> <4e89b426041027102347601f19@mail.gmail.com> Content-Type: text/plain Organization: MindNever Dot Org Message-ID: <1098898240.4898.91.camel@mravojed> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 27 Oct 2004 19:30:41 +0200 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on leya.mindnever.org X-Spam-Level: X-Spam-Status: No, hits=-4.3 required=4.0 tests=AWL,BAYES_00,RCVD_IN_SBL autolearn=no version=2.63 Subject: Re: [PHP-DEV] [PATCH] Bug fix for #29770, but for PHP 4.3.9 From: vladimir@mindnever.org (Vladimir Zidar) I didn't know that such function exist. I can change my patch, and everybody should feel better.. ok ? On Wed, 2004-10-27 at 19:23, Wez Furlong wrote: > I'd feel slightly happier if it used spprintf() instead of manually > calculating the buffer length, but otherwise I'm okay with it. > > --Wez. > > > On Wed, 27 Oct 2004 09:51:52 -0700, Andi Gutmans wrote: > > This patch makes sense to me. Anyone have a problem with it? > > > > Andi > > > > > > > > At 02:14 PM 10/27/2004 +0200, Vladimir Zidar wrote: > > > When safe_mode is set to 'on', popen() uses char buf[1024] to build > > > argument list. This is not good, as it truncates command line without notice. > > > This is NOT operating system limit - as noted on bugreport, but PHP bug. > > > > > > If anybody cares, here is fix for this bug under 4.3.9: > > > > > > http://leya.mindnever.org/~mr_w/php-popen.patch.gz > > > > > > PS, didn't have time to look at PHP 5 yet, but I suppose this fix could > > >work also with minor tweaks. > > > > > > > > >-- > > >Vladimir Zidar, Programmer > > > > > >MindNever Foodstuff TRDG. > > >Head Office Branch > > > > > >Tel: +381-63-550161, +385-98-9574261 > > >http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org > > > > > >-- > > >PHP Internals - PHP Runtime Development Mailing List > > >To unsubscribe, visit: http://www.php.net/unsub.php > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > -- Vladimir Zidar, Programmer MindNever Foodstuff TRDG. Head Office Branch Tel: +381-63-550161, +385-98-9574261 http://www.mindnever.org, icq: 15414204, mail: mr_W@mindnever.org