suggested patch for ext/standard/html.c for correct htmlentity'ing of cyrillic characters View as Markdown

+1 from me (I will apply it to PHP5).

This looks like a suitable candidate for 4.3.2 also; no new code is
introduced by this patch, merely a lookup table, and adding more
encodings can be regarded as a fix.

Opinions?

--Wez.

Hello, all.

Attached patch provides cyrillic character sets support to
htmlentities(), useful for those who wants to see correct cyrillic
letters after using this function (at this moment htmlentities()
successfully breaks cyrillic characters).
KOI8-R, Windows-1251 & CP866 encodings are supported.

I've tested this patch with PHP-CVS & PHP 4.3.2RC1 - it seems to be
working correctly.
Someone who has enough karma - please, take a look at it and apply it
if it's ok.

--
Wbr,
Antony Dovgal aka tony2001 mailto:tony2001@phpclub.net
http://phpclub.net

Stand for something or you will fall for nothing.

Your patch has been committed with a slight enhancement to the cp1251
table. Thanks.

Moriyoshi

Antony Dovgal tony2001@phpclub.net wrote:

Hello, all.

Attached patch provides cyrillic character sets support to
htmlentities(), useful for those who wants to see correct cyrillic
letters after using this function (at this moment htmlentities()
successfully breaks cyrillic characters).
KOI8-R, Windows-1251 & CP866 encodings are supported.

I've tested this patch with PHP-CVS & PHP 4.3.2RC1 - it seems to be
working correctly.
Someone who has enough karma - please, take a look at it and apply it
if it's ok.