Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:141 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5277 invoked from network); 22 Mar 2003 10:59:15 -0000 Received: from unknown (HELO cs78146114.pp.htv.fi) (62.78.146.114) by pb1.pair.com with SMTP; 22 Mar 2003 10:59:15 -0000 Received: from localhost (jani@localhost) by cs78146114.pp.htv.fi (8.11.6/8.11.6) with ESMTP id h2MAxAP01583; Sat, 22 Mar 2003 12:59:10 +0200 X-Authentication-Warning: cs78146114.pp.htv.fi: jani owned process doing -bs Date: Sat, 22 Mar 2003 12:59:10 +0200 (EET) Sender: jani@cs78146114.pp.htv.fi Reply-To: Jani Taskinen To: Wez Furlong cc: Antony Dovgal , In-Reply-To: Message-ID: References: <20030321124105.6a71c972.tony2001@phpclub.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] suggested patch for ext/standard/html.c for correct htmlentity'ing of cyrillic characters From: sniper@iki.fi (Jani Taskinen) Go ahead and commit it then..and MFH.. --Jani On Fri, 21 Mar 2003, Wez Furlong wrote: >+1 from me (I will apply it to PHP5). > >This looks like a suitable candidate for 4.3.2 also; no new code is >introduced by this patch, merely a lookup table, and adding more >encodings can be regarded as a fix. > >Opinions? > >--Wez. > >On Fri, 21 Mar 2003, Antony Dovgal wrote: > >> Hello, all. >> >> Attached patch provides cyrillic character sets support to >> htmlentities(), useful for those who wants to see correct cyrillic >> letters after using this function (at this moment htmlentities() >> successfully breaks cyrillic characters). >> KOI8-R, Windows-1251 & CP866 encodings are supported. >> >> I've tested this patch with PHP-CVS & PHP 4.3.2RC1 - it seems to be >> working correctly. >> Someone who has enough karma - please, take a look at it and apply it >> if it's ok. >> >> >> -- >> Wbr, >> Antony Dovgal aka tony2001 mailto:tony2001@phpclub.net >> http://phpclub.net >> --- >> Stand for something or you will fall for nothing. >> > > -- <- For Sale! ->