Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Fri, 21 Mar 2003 10:51:47 +0000 (GMT)
To: Antony Dovgal <tony2001@phpclub.net>
cc: internals@lists.php.net
In-Reply-To: <20030321124105.6a71c972.tony2001@phpclub.net>
Message-ID: <Pine.LNX.4.53.0303211050320.403@localhost.localdomain>
References: <20030321124105.6a71c972.tony2001@phpclub.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] suggested patch for ext/standard/html.c for correct
 htmlentity'ing of cyrillic characters
From: wez@thebrainroom.com (Wez Furlong)

+1 from me (I will apply it to PHP5).

This looks like a suitable candidate for 4.3.2 also; no new code is
introduced by this patch, merely a lookup table, and adding more
encodings can be regarded as a fix.

Opinions?

--Wez.

On Fri, 21 Mar 2003, Antony Dovgal wrote:

> Hello, all.
>
>  Attached patch provides cyrillic character sets support to
> htmlentities(), useful for those who wants to see correct cyrillic
> letters after using this function (at this moment htmlentities()
> successfully breaks cyrillic characters).
>  KOI8-R, Windows-1251 & CP866 encodings are supported.
>
>  I've tested this patch with PHP-CVS & PHP 4.3.2RC1 - it seems to be
> working correctly.
>  Someone who has enough karma - please, take a look at it and apply it
> if it's ok.
>
>
> --
> Wbr,
> Antony Dovgal aka tony2001	mailto:tony2001@phpclub.net
> http://phpclub.net
> ---
> Stand for something or you will fall for nothing.
>