Hei,
This is Rasmus' patch including a configure option
"--disable-path-normalization" to enable this patch. By default this
option is of course turned off.
I am planning to commit this patch after 4.3.9 is released too, in case
there are no good objections.
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
There's an #if 0 in there that probably shouldn't be
--Wez.
On Tue, 14 Sep 2004 14:10:52 +0200 (CEST), Derick Rethans
derick@derickrethans.nl wrote:
Hei,
This is Rasmus' patch including a configure option
"--disable-path-normalization" to enable this patch. By default this
option is of course turned off.I am planning to commit this patch after 4.3.9 is released too, in case
there are no good objections.Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
There's an #if 0 in there that probably shouldn't be
Yeah, the whole stuff can be removed, as it's added in later again :)
I'll create a new patch for it here.
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
There's an #if 0 in there that probably shouldn't be
Yeah, the whole stuff can be removed, as it's added in later again :)
I'll create a new patch for it here.
hmm, no, this was a different patch. No clue why he put that in; Rasmus,
can you clarify?
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
To eliminate an fstat() most likely; it can stay, but it should
probably changed to #ifndef SKIP_PATH_CHECKS instead.
--Wez.
On Tue, 14 Sep 2004 14:50:09 +0200 (CEST), Derick Rethans
derick@php.net wrote:
There's an #if 0 in there that probably shouldn't be
Yeah, the whole stuff can be removed, as it's added in later again :)
I'll create a new patch for it here.hmm, no, this was a different patch. No clue why he put that in; Rasmus,
can you clarify?Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
There's an #if 0 in there that probably shouldn't be
Yeah, the whole stuff can be removed, as it's added in later again :)
I'll create a new patch for it here.hmm, no, this was a different patch. No clue why he put that in; Rasmus,
can you clarify?
That should have been a #ifndef SKIP_PATH_CHECKS there. And it is there
to get rid of a non-critical ftell().
And yes, there is no doubt that this patch can critically alter the way
PHP works and has the potential to break all sorts of stuff. Anything
that relies on PHP knowing the full path will break. I had to fix both
xdebug and APC, for example. At the same time, enough people have asked
me about it that it probably should be more accessible.
-Rasmus
That should have been a #ifndef SKIP_PATH_CHECKS there. And it is there
to get rid of a non-criticalftell().
Attached is the patch with this corrected, and corrected white space.
And yes, there is no doubt that this patch can critically alter the way
PHP works and has the potential to break all sorts of stuff. Anything
that relies on PHP knowing the full path will break. I had to fix both
xdebug and APC, for example. At the same time, enough people have asked
me about it that it probably should be more accessible.
I agree, there are a lot of people who might benefit from it (and do
already!) and thus the reason for me to put it into something usable for
everybody so that 1) rasmus doesn't have to maintain the patch anymore
and 2) users don't have to keep updating their PHP whenever they upgrade
PHP.
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
Derick Rethans wrote:
That should have been a #ifndef SKIP_PATH_CHECKS there. And it is there
to get rid of a non-criticalftell().Attached is the patch with this corrected, and corrected white space.
And yes, there is no doubt that this patch can critically alter the way
PHP works and has the potential to break all sorts of stuff. Anything
that relies on PHP knowing the full path will break. I had to fix both
xdebug and APC, for example. At the same time, enough people have asked
me about it that it probably should be more accessible.I agree, there are a lot of people who might benefit from it (and do
already!) and thus the reason for me to put it into something usable for
everybody so that 1) rasmus doesn't have to maintain the patch anymore
and 2) users don't have to keep updating their PHP whenever they upgrade
PHP.Derick
Both points make sense. Just name the configure option well and put big warnings there
that when the option is switched on this may lead to crashing applications.
Andrey
Both points make sense. Just name the configure option well and put big warnings there
that when the option is switched on this may lead to crashing applications.
Nothing will crash, it's just that include_once might fail if you're
using two different paths to include it. No big deal and easy to fix too
IF you need this kind of performance increase. Big warnings is fine with
me :)
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
I don't think we should have this patch in the distribution. It shouldn't
be that accessible as it has the potential to break behavior of both apps
and plugins. I think it belongs in a patches repository such as
http://www.zend.com/zend/week/pat/ (doesn't have to be that one in
particular, but something like that).
(There are also several coding style issues with the patch if we do decide
to accept it)
Zeev
At 15:10 14/09/2004, Derick Rethans wrote:
Hei,
This is Rasmus' patch including a configure option
"--disable-path-normalization" to enable this patch. By default this
option is of course turned off.I am planning to commit this patch after 4.3.9 is released too, in case
there are no good objections.Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org
Hey Derick and all,
As I mentioned in the past, I think solving it in a completely compatible
manner is the best way to go.
I sent out the realpath() cache patch which addresses the most problematic
file system issues (and if there are any other things we could probably
address too).
I think there's a big advantage in having something which is completely
compatible because we could enable it by default and all PHP users would
benefit from it.
I volunteer to put some gas on getting this patch production ready. Maybe I
can send a new version in a couple of days and discuss what else it is missing?
Andi
At 02:10 PM 9/14/2004 +0200, Derick Rethans wrote:
Hei,
This is Rasmus' patch including a configure option
"--disable-path-normalization" to enable this patch. By default this
option is of course turned off.I am planning to commit this patch after 4.3.9 is released too, in case
there are no good objections.Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org