Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12799 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 63716 invoked by uid 1010); 14 Sep 2004 14:54:38 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 63641 invoked from network); 14 Sep 2004 14:54:37 -0000 Received: from unknown (HELO colo.lerdorf.com) (66.198.51.121) by pb1.pair.com with SMTP; 14 Sep 2004 14:54:37 -0000 Received: from [192.168.1.105] (c-24-6-200-247.client.comcast.net [24.6.200.247]) by colo.lerdorf.com (8.13.1/8.13.1/Debian-13) with ESMTP id i8EEsWTb032097; Tue, 14 Sep 2004 07:54:32 -0700 Date: Tue, 14 Sep 2004 07:54:28 -0700 (PDT) X-X-Sender: rasmus@t42p.lerdorf.com To: Derick Rethans cc: Wez Furlong , PHP Developers Mailing List In-Reply-To: Message-ID: References: <4e89b426040914054034832df8@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option From: rasmus@php.net (Rasmus Lerdorf) On Tue, 14 Sep 2004, Derick Rethans wrote: > On Tue, 14 Sep 2004, Derick Rethans wrote: > > > On Tue, 14 Sep 2004, Wez Furlong wrote: > > > > > There's an #if 0 in there that probably shouldn't be > > > > Yeah, the whole stuff can be removed, as it's added in later again :) > > I'll create a new patch for it here. > > hmm, no, this was a different patch. No clue why he put that in; Rasmus, > can you clarify? That should have been a #ifndef SKIP_PATH_CHECKS there. And it is there to get rid of a non-critical ftell(). And yes, there is no doubt that this patch can critically alter the way PHP works and has the potential to break all sorts of stuff. Anything that relies on PHP knowing the full path will break. I had to fix both xdebug and APC, for example. At the same time, enough people have asked me about it that it probably should be more accessible. -Rasmus