Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12804 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94609 invoked by uid 1010); 14 Sep 2004 17:19:22 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 94552 invoked from network); 14 Sep 2004 17:19:22 -0000 Received: from unknown (HELO iko.gotobg.net) (80.168.8.116) by pb1.pair.com with SMTP; 14 Sep 2004 17:19:22 -0000 Received: from pd9519bf2.dip.t-dialin.net ([217.81.155.242] helo=[192.168.0.36]) by iko.gotobg.net with asmtp (Exim 4.41) id 1C7Gxh-0002Ah-3g; Tue, 14 Sep 2004 20:19:25 +0300 Message-ID: <414727D7.2090509@hristov.com> Date: Tue, 14 Sep 2004 19:18:15 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040817 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Derick Rethans CC: PHP Developers Mailing List References: <4e89b426040914054034832df8@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - iko.gotobg.net X-AntiAbuse: Original Domain - lists.php.net X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - hristov.com X-Source: X-Source-Args: X-Source-Dir: Subject: Re: [PHP-DEV] Patch: Rasmus statcallpatch with configure option From: php@hristov.com (Andrey Hristov) Derick Rethans wrote: > On Tue, 14 Sep 2004, Rasmus Lerdorf wrote: > > >>That should have been a #ifndef SKIP_PATH_CHECKS there. And it is there >>to get rid of a non-critical ftell(). > > > Attached is the patch with this corrected, and corrected white space. > > >>And yes, there is no doubt that this patch can critically alter the way >>PHP works and has the potential to break all sorts of stuff. Anything >>that relies on PHP knowing the full path will break. I had to fix both >>xdebug and APC, for example. At the same time, enough people have asked >>me about it that it probably should be more accessible. > > > I agree, there are a lot of people who might benefit from it (and do > already!) and thus the reason for me to put it into something usable for > everybody so that 1) rasmus doesn't have to maintain the patch anymore > and 2) users don't have to keep updating their PHP whenever they upgrade > PHP. > > Derick > Both points make sense. Just name the configure option well and put big warnings there that when the option is switched on this _may_ lead to crashing applications. Andrey