This came up in a conversation I had with Sergey and Pierrick earlier
today...
As release managers go through open PRs, we tag them with "Waiting on
Review" to indicate to other internals devs that a PR needs review.
In fact, we have quite a few that are currently waiting on review:
https://github.com/php/php-src/pulls?q=is%3Aopen+is%3Apr+label%3A%22Waiting+on+Review%22
Unfortunately, we don't always know who is the best person to review a
PR, so we hope that others are checking to see whether there are PRs
that need reviews in their area of expertise.
It would be helpful to know from whom we should request reviews, based
on the area of the code (i.e., ext, Zend, main, etc.). One way is to set
up a table on the wiki with this information. Another way is to use a
GitHub CODEOWNERS file,^1 which takes care of requesting the reviews
automatically.
I've opened a draft PR to discuss the CODEOWNERS file approach:
https://github.com/php/php-src/pull/8670
I don't know how feasible it is to maintain a list like this for the PHP
project. Ideally, folks would add themselves to the list and
self-identify which areas of the code base they want to have
automatically request them for reviews.
What do others think?
--
Cheers,
Ben
This came up in a conversation I had with Sergey and Pierrick earlier
today...As release managers go through open PRs, we tag them with "Waiting on
Review" to indicate to other internals devs that a PR needs review.In fact, we have quite a few that are currently waiting on review:
https://github.com/php/php-src/pulls?q=is%3Aopen+is%3Apr+label%3A%22Waiting+on+Review%22
Unfortunately, we don't always know who is the best person to review a
PR, so we hope that others are checking to see whether there are PRs
that need reviews in their area of expertise.It would be helpful to know from whom we should request reviews, based
on the area of the code (i.e., ext, Zend, main, etc.). One way is to set
up a table on the wiki with this information. Another way is to use a
GitHub CODEOWNERS file,[^1] which takes care of requesting the reviews
automatically.I've opened a draft PR to discuss the CODEOWNERS file approach:
https://github.com/php/php-src/pull/8670I don't know how feasible it is to maintain a list like this for the PHP
project. Ideally, folks would add themselves to the list and
self-identify which areas of the code base they want to have
automatically request them for reviews.What do others think?
FWIW, there is already EXTENSIONS[1]. There even was an RFC about
that[2] some years ago, but in hindsight, that didn't work out. One of
the problems is that we cannot unbundle some extensions even if they
have no maintainer (e.g. Spl). And it is not likely, that someone steps
up as maintainer of such extensions; it's more likely that several
contributors will occassionally have a look at issues regarding such
extensions.
So I doubt that a CODEOWNERS file will be of much use.
[1] https://github.com/php/php-src/blob/master/EXTENSIONS
[2] https://wiki.php.net/rfc/umaintained_extensions
--
Christoph M. Becker
This came up in a conversation I had with Sergey and Pierrick earlier
today...As release managers go through open PRs, we tag them with "Waiting on
Review" to indicate to other internals devs that a PR needs review.In fact, we have quite a few that are currently waiting on review:
https://github.com/php/php-src/pulls?q=is%3Aopen+is%3Apr+label%3A%22Waiting+on+Review%22
Unfortunately, we don't always know who is the best person to review a
PR, so we hope that others are checking to see whether there are PRs
that need reviews in their area of expertise.It would be helpful to know from whom we should request reviews, based
on the area of the code (i.e., ext, Zend, main, etc.). One way is to set
up a table on the wiki with this information. Another way is to use a
GitHub CODEOWNERS file,[^1] which takes care of requesting the reviews
automatically.I've opened a draft PR to discuss the CODEOWNERS file approach:
https://github.com/php/php-src/pull/8670I don't know how feasible it is to maintain a list like this for the PHP
project. Ideally, folks would add themselves to the list and
self-identify which areas of the code base they want to have
automatically request them for reviews.What do others think?
FWIW, there is already EXTENSIONS[1]. There even was an RFC about
that[2] some years ago, but in hindsight, that didn't work out. One of
the problems is that we cannot unbundle some extensions even if they
have no maintainer (e.g. Spl). And it is not likely, that someone steps
up as maintainer of such extensions; it's more likely that several
contributors will occassionally have a look at issues regarding such
extensions.So I doubt that a CODEOWNERS file will be of much use.
[1] https://github.com/php/php-src/blob/master/EXTENSIONS
[2] https://wiki.php.net/rfc/umaintained_extensions--
Christoph M. Becker--
To unsubscribe, visit: https://www.php.net/unsub.php
So I doubt that a CODEOWNERS file will be of much use.
It is not necessary that the owners file covers every file in the
repo. But for aspects of the code that do have an owner, having an
owner file makes things much simpler.