Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:117845 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 4685 invoked from network); 1 Jun 2022 10:38:19 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 1 Jun 2022 10:38:19 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 1C8DE180384 for ; Wed, 1 Jun 2022 05:22:34 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 1 Jun 2022 05:22:33 -0700 (PDT) Received: by mail-oi1-f170.google.com with SMTP id m82so2362294oif.13 for ; Wed, 01 Jun 2022 05:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yj65DarztbXxgZAuwjqfu+4YU3xULXNabtcp4Y/UWwI=; b=X8xJfFkVdy7WOfWz5D0uI0jEgA/hQIKtAKRq4Q1RUFz6OXNktjC64djXSMh5Hb+/de ebit2hNh6OrfQolXZ1NF/aaC8HFbGhWxdCI3AciQc2hxDZlbyLxVu59YiiYlvFuhy5Zs baCqrFRDtIDtKPmG+YTHXB4merLE8j6bBmLpqPDxiEgftBCVFICqnRY7kAxejhDQAact zd4UNOVW4uHGQ/hsVN43CqPRzgys1IR1CTaBvdNhDc9hgIUoYB+qMU1A6J8GEu5nzkoE uh2ppGOFAKfTtyHt4NHLq9RfkLw7/KKZsS+wqPXbPBzuIYR1vu3aPIwlFObFDpJXj0j3 zhkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yj65DarztbXxgZAuwjqfu+4YU3xULXNabtcp4Y/UWwI=; b=BqBa0qcToZt8CHAYnEO7F8+Wz0fOF0BvYMSHCr2QnFl7e1ggN4HYfsa2v6esnmIlNN s91BwKBezwaP8MaGvizwfkeSSLcm0mIpE/tspapi3jyvHU3R/wXksHd4N34QVADX5a99 Bf5wcLIQEC5lLvgMrQMj52xEiQlBJRMQ5sBt9Shuuqy7XNp72iuyxnLhrjRbMfucdlpP Yn5pcNC88yP/Lw4bpTFcpWY07jyt3VaP0g9GICe+vv8GVFi0f9WF6RadggtbSN3+lUxQ ZDR12RgaERPP0X0eEEZhx4CK59XHQ/PEj2GRiyZmTJCVIrUhmFWW0UERY5dYYxOhXlNn 2yUQ== X-Gm-Message-State: AOAM531sWJ9Jc0Qhqz2Oe4jy4HsqwUyaZlJPhI9UGd05RZhsYx3qQc1H mDAXo9eRO1unWmh4uRI/886WYtTPQHTO6H6Pk4g= X-Google-Smtp-Source: ABdhPJzQZNUwVEGI3OuwLHqJlxcvpKRqDvwfMN/tn09wryp1ZowJocrzutLZIAL63Kn2IuMew7bEifzqDHmP82IMd2A= X-Received: by 2002:a05:6808:3083:b0:32b:afd:72ef with SMTP id bl3-20020a056808308300b0032b0afd72efmr15067407oib.36.1654086153020; Wed, 01 Jun 2022 05:22:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 1 Jun 2022 14:22:21 +0200 Message-ID: To: "Christoph M. Becker" Cc: Ben Ramsey , internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Re: Requesting reviews on php-src pull requests From: landers.robert@gmail.com (Robert Landers) On Wed, Jun 1, 2022 at 11:07 AM Christoph M. Becker wrote: > > On 31.05.2022 at 23:53, Ben Ramsey wrote: > > > This came up in a conversation I had with Sergey and Pierrick earlier > > today... > > > > As release managers go through open PRs, we tag them with "Waiting on > > Review" to indicate to other internals devs that a PR needs review. > > > > In fact, we have quite a few that are currently waiting on review: > > > > https://github.com/php/php-src/pulls?q=is%3Aopen+is%3Apr+label%3A%22Waiting+on+Review%22 > > > > > > Unfortunately, we don't always know who is the best person to review a > > PR, so we hope that others are checking to see whether there are PRs > > that need reviews in their area of expertise. > > > > It would be helpful to know from whom we should request reviews, based > > on the area of the code (i.e., ext, Zend, main, etc.). One way is to set > > up a table on the wiki with this information. Another way is to use a > > GitHub CODEOWNERS file,[^1] which takes care of requesting the reviews > > automatically. > > > > I've opened a draft PR to discuss the CODEOWNERS file approach: > > https://github.com/php/php-src/pull/8670 > > > > I don't know how feasible it is to maintain a list like this for the PHP > > project. Ideally, folks would add themselves to the list and > > self-identify which areas of the code base they want to have > > automatically request them for reviews. > > > > What do others think? > > FWIW, there is already EXTENSIONS[1]. There even was an RFC about > that[2] some years ago, but in hindsight, that didn't work out. One of > the problems is that we cannot unbundle some extensions even if they > have no maintainer (e.g. Spl). And it is not likely, that someone steps > up as maintainer of such extensions; it's more likely that several > contributors will occassionally have a look at issues regarding such > extensions. > > So I doubt that a CODEOWNERS file will be of much use. > > [1] > [2] > > -- > Christoph M. Becker > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > > So I doubt that a CODEOWNERS file will be of much use. It is not necessary that the owners file covers every file in the repo. But for aspects of the code that do have an owner, having an owner file makes things much simpler.