Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117844
Message-ID: <e9e7aa28-a699-e00a-d080-846976cf2547@gmx.de>
Date: Wed, 1 Jun 2022 11:07:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Content-Language: de-DE
To: Ben Ramsey <ramsey@php.net>, internals@lists.php.net
References: <php.internals-117843@news.php.net>
In-Reply-To: <php.internals-117843@news.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Requesting reviews on php-src pull requests
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 31.05.2022 at 23:53, Ben Ramsey wrote:

> This came up in a conversation I had with Sergey and Pierrick earlier
> today...
>
> As release managers go through open PRs, we tag them with "Waiting on
> Review" to indicate to other internals devs that a PR needs review.
>
> In fact, we have quite a few that are currently waiting on review:
>
> https://github.com/php/php-src/pulls?q=3Dis%3Aopen+is%3Apr+label%3A%22Wa=
iting+on+Review%22
>
>
> Unfortunately, we don't always know who is the best person to review a
> PR, so we hope that others are checking to see whether there are PRs
> that need reviews in their area of expertise.
>
> It would be helpful to know from whom we should request reviews, based
> on the area of the code (i.e., ext, Zend, main, etc.). One way is to set
> up a table on the wiki with this information. Another way is to use a
> GitHub CODEOWNERS file,[^1] which takes care of requesting the reviews
> automatically.
>
> I've opened a draft PR to discuss the CODEOWNERS file approach:
> https://github.com/php/php-src/pull/8670
>
> I don't know how feasible it is to maintain a list like this for the PHP
> project. Ideally, folks would add themselves to the list and
> self-identify which areas of the code base they want to have
> automatically request them for reviews.
>
> What do others think?

FWIW, there is already EXTENSIONS[1].  There even was an RFC about
that[2] some years ago, but in hindsight, that didn't work out.  One of
the problems is that we cannot unbundle some extensions even if they
have no maintainer (e.g. Spl).  And it is not likely, that someone steps
up as maintainer of such extensions; it's more likely that several
contributors will occassionally have a look at issues regarding such
extensions.

So I doubt that a CODEOWNERS file will be of much use.

[1] <https://github.com/php/php-src/blob/master/EXTENSIONS>
[2] <https://wiki.php.net/rfc/umaintained_extensions>

=2D-
Christoph M. Becker