[PHP-CVS] com php-src: Missing param in arginfo_pdostatement_setfetchmode: ext/pdo/pdo_stmt.c

7 years ago by Sebastian Bergmann — view source — reply

unread

Am 14.02.2019 um 08:13 schrieb Gabriel Caruso:

Commit: ad75511c8e5461cc6ba5cf7aad8f5265615560a8
Author: Gabriel Caruso carusogabriel34@gmail.com Fri, 16 Feb 2018 21:29:34 -0200
Parents: d57c56cd6304b92db83180e7939eb6288c3a18af
Branches: master

Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ad75511c8e5461cc6ba5cf7aad8f5265615560a8

Log:
Missing param in arginfo_pdostatement_setfetchmode

PDO::setFetchMode receives up to 3 params

Are you sure you only want to add this to master (PHP 8) and not (at
least) also to PHP 7.4?

7 years ago by Nikita Popov — view source — reply

unread

On Thu, Feb 14, 2019 at 8:38 AM Sebastian Bergmann sebastian@php.net
wrote:

Am 14.02.2019 um 08:13 schrieb Gabriel Caruso:

Commit: ad75511c8e5461cc6ba5cf7aad8f5265615560a8
Author: Gabriel Caruso carusogabriel34@gmail.com Fri, 16
Feb 2018 21:29:34 -0200
Parents: d57c56cd6304b92db83180e7939eb6288c3a18af
Branches: master

Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=ad75511c8e5461cc6ba5cf7aad8f5265615560a8

Log:
Missing param in arginfo_pdostatement_setfetchmode

PDO::setFetchMode receives up to 3 params

Are you sure you only want to add this to master (PHP 8) and not (at
least) also to PHP 7.4?

Arginfo changes for methods are almost always BC breaking due to LSP
checks, so they can only go into major versions.

Nikita