Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104397
Return-Path: <nikita.ppv@gmail.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 78131 invoked from network); 14 Feb 2019 11:54:13 -0000
Received: from unknown (HELO mail-it1-f177.google.com) (209.85.166.177)
  by pb1.pair.com with SMTP; 14 Feb 2019 11:54:13 -0000
Received: by mail-it1-f177.google.com with SMTP id p4so10674492itc.4
        for <internals@lists.php.net>; Thu, 14 Feb 2019 00:37:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=9FFT7q4a0KmmIUmSuSuwLIK7+Opjpk1eJ8OYB8Fqa3s=;
        b=L1YWANUDPWfEEJuspvNjrc/Se9tiiXsihopoz0yYW4p2oT4wVy7/Iwh/0kRZKhC7DP
         hDWl5VoDnblzGsIZfJzoM8BtEqJb+k9ngdTf2nM+/5kLMmQChXT/G3m1ijGQjmOm7BrY
         4TROKbr/Wr5KkFd0kTWQpZzwyre08sx45+ikG5t/YLyruI5xRjh4ChoGr+CkI3C5Ups0
         L+wnxQvOwRcZ8RyEAXmAMW99wXOCC0NDnhak+N12Xpz406vGq94a13QSC5pIUBr0MEvr
         xKLcwJTILq/YhxEe7WsoPdAd2lzRzl1sugiEyYXLlQNa2hxzmRRlwxVdOyaefYAGBBvG
         /W5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=9FFT7q4a0KmmIUmSuSuwLIK7+Opjpk1eJ8OYB8Fqa3s=;
        b=MkIe7C1ie7iAQq2qNn/IjiztKutB6e+URpN8SdhCsj6a8Qy9uQZopMyMOM/lwQXK7X
         JGnFOafgtLCnWHkTCnz4zmqQSX+ZNHDf7/0rA6FtdF2HSxBoFthJLAkVkQCCqzH4ORKN
         A81spNXMUpVhECLAu5deckzPsu4+Knqf77cNICuE7lsq9ORf93OreyswPQF7QwEAecf3
         bo3hV3Io7lEwxx0zrosgYy9tRsRP9l9a8xSufZHHzL4K/rmghfWP5nBAmbpK09QaWjNK
         m1gF+XrEg6jJvK/wPlm8pS5lmWgNrHZbTBuCaw6QZufLW8YFiVzj+FQUnY3v1UD4lcxX
         dDww==
X-Gm-Message-State: AHQUAubdUxDBhsd2WhJH+ZKHbLVFegBPLccgj3vrbfXYU9nfqR1SA7Ad
	wO9yumMdRR1ShBiTRxa1JVbDnx1c/24uZ5n//f6owQ==
X-Google-Smtp-Source: AHgI3IZORB3JlAdJj5w3B/B9lfQWD3LVrREdx6wcczCJ49uYVNJKLqcBj0ybVh+YXMz47P2fy5HqcGrKTL3LSZFP2pk=
X-Received: by 2002:a24:de87:: with SMTP id d129mr1320225itg.110.1550133453169;
 Thu, 14 Feb 2019 00:37:33 -0800 (PST)
MIME-Version: 1.0
References: <php-mail-f4daf09960e33f6a2161699473fa2139971424726@git.php.net> <943cbb3b-f35e-80a2-b9ce-bcb80fbd9abf@php.net>
In-Reply-To: <943cbb3b-f35e-80a2-b9ce-bcb80fbd9abf@php.net>
Date: Thu, 14 Feb 2019 09:37:16 +0100
Message-ID: <CAF+90c-woAv1wX6dKGVsnwpTvnLrkx-pO_P+94ipfc7+JEeFuQ@mail.gmail.com>
To: Sebastian Bergmann <sebastian@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d4a77e0581d69190"
Subject: Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Missing param in
 arginfo_pdostatement_setfetchmode: ext/pdo/pdo_stmt.c
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000d4a77e0581d69190
Content-Type: text/plain; charset="UTF-8"

On Thu, Feb 14, 2019 at 8:38 AM Sebastian Bergmann <sebastian@php.net>
wrote:

> Am 14.02.2019 um 08:13 schrieb Gabriel Caruso:
> > Commit:    ad75511c8e5461cc6ba5cf7aad8f5265615560a8
> > Author:    Gabriel Caruso <carusogabriel34@gmail.com>         Fri, 16
> Feb 2018 21:29:34 -0200
> > Parents:   d57c56cd6304b92db83180e7939eb6288c3a18af
> > Branches:  master
> >
> > Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=ad75511c8e5461cc6ba5cf7aad8f5265615560a8
> >
> > Log:
> > Missing param in arginfo_pdostatement_setfetchmode
> >
> > PDO::setFetchMode receives up to 3 params
>
> Are you sure you only want to add this to master (PHP 8) and not (at
> least) also to PHP 7.4?
>

Arginfo changes for methods are almost always BC breaking due to LSP
checks, so they can only go into major versions.

Nikita

--000000000000d4a77e0581d69190--