Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:104394
Return-Path: <sebastian@php.net>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 62015 invoked from network); 14 Feb 2019 10:54:53 -0000
Received: from unknown (HELO scarlet.netpirates.net) (188.94.27.5)
  by pb1.pair.com with SMTP; 14 Feb 2019 10:54:53 -0000
Received: from p5de2ca58.dip0.t-ipconnect.de ([93.226.202.88] helo=[192.168.178.42])
	by scarlet.netpirates.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
	(Exim 4.91)
	(envelope-from <sebastian@php.net>)
	id 1guBb3-0001XF-BU
	for internals@lists.php.net; Thu, 14 Feb 2019 08:38:13 +0100
To: internals@lists.php.net
References: <php-mail-f4daf09960e33f6a2161699473fa2139971424726@git.php.net>
Message-ID: <943cbb3b-f35e-80a2-b9ce-bcb80fbd9abf@php.net>
Date: Thu, 14 Feb 2019 08:38:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <php-mail-f4daf09960e33f6a2161699473fa2139971424726@git.php.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-CVS] com php-src: Missing param in
 arginfo_pdostatement_setfetchmode: ext/pdo/pdo_stmt.c
From: sebastian@php.net (Sebastian Bergmann)

Am 14.02.2019 um 08:13 schrieb Gabriel Caruso:
> Commit:    ad75511c8e5461cc6ba5cf7aad8f5265615560a8
> Author:    Gabriel Caruso <carusogabriel34@gmail.com>         Fri, 16 Feb 2018 21:29:34 -0200
> Parents:   d57c56cd6304b92db83180e7939eb6288c3a18af
> Branches:  master
> 
> Link:       http://git.php.net/?p=php-src.git;a=commitdiff;h=ad75511c8e5461cc6ba5cf7aad8f5265615560a8
> 
> Log:
> Missing param in arginfo_pdostatement_setfetchmode
> 
> PDO::setFetchMode receives up to 3 params

Are you sure you only want to add this to master (PHP 8) and not (at 
least) also to PHP 7.4?