[VOTE] JSON_THROW_ON_ERROR

6 years ago by Andrea Faulds — view source

unread

Hi everyone,

https://wiki.php.net/rfc/json_throw_on_error

Voting opens today, 2017-09-25, and ends in 10 days' time, 2017-10-05.
Under the terms of the voting RFC this only needs 50%+1 but I'll feel
guilty if it's not 2/3 so it's 2/3.

Happy voting, please ask if there's anything needing clarifying.

Thanks.

Andrea Faulds
https://ajf.me/

6 years ago by Derick Rethans — view source

unread

Hi everyone,

https://wiki.php.net/rfc/json_throw_on_error

Voting opens today, 2017-09-25, and ends in 10 days' time, 2017-10-05. Under
the terms of the voting RFC this only needs 50%+1 but I'll feel guilty if it's
not 2/3 so it's 2/3.

Happy voting, please ask if there's anything needing clarifying.

I'm going to be in favour, but I was wondering whether the name of the
exception "JsonException" is a good thing? I would still introduce it,
but probably subclass a "JsonCodingException" to signal just an
exceptional code while encoding/decoding. I can see future exceptions
being thrown from the extension, where you then get confusion (or
conflicts with error codes).

cheers,
Derick

--
https://derickrethans.nl | https://xdebug.org | https://dram.io
Like Xdebug? Consider a donation: https://xdebug.org/donate.php
twitter: @derickr and @xdebug

6 years ago by Niklas Keller — view source

unread

2017-09-26 12:01 GMT+02:00 Derick Rethans derick@php.net:

Hi everyone,

https://wiki.php.net/rfc/json_throw_on_error

Voting opens today, 2017-09-25, and ends in 10 days' time, 2017-10-05.
Under
the terms of the voting RFC this only needs 50%+1 but I'll feel guilty
if it's
not 2/3 so it's 2/3.

Happy voting, please ask if there's anything needing clarifying.

I'm going to be in favour, but I was wondering whether the name of the
exception "JsonException" is a good thing? I would still introduce it,
but probably subclass a "JsonCodingException" to signal just an
exceptional code while encoding/decoding. I can see future exceptions
being thrown from the extension, where you then get confusion (or
conflicts with error codes).

Which future exceptions can you imagine?

Regards, Niklas

6 years ago by Andrea Faulds — view source

unread

Hi again,

I'm happy to report JSON_THROW_ON_ERROR was unanimously accepted with 23
votes.

Hopefully it can be merged soon. Now would be a good time to review the
pull request if desired.

Thanks for discussing and voting!

--
Andrea Faulds
https://ajf.me/