Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100776
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.219 cause and error)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1709261100240.3254@singlemalt.home.derickrethans.nl>
References: <C9.6A.05407.E7379C95@pb1.pair.com> <alpine.DEB.2.20.1709261100240.3254@singlemalt.home.derickrethans.nl>
Date: Tue, 26 Sep 2017 13:42:07 +0200
Message-ID: <CANUQDCjG9e=bA3tFUzu8WQWjWej72ajy5_6uGkijRw6dqj+tLw@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Andrea Faulds <ajf@ajf.me>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a11428394379170055a162a0a"
Subject: Re: [PHP-DEV] [VOTE] JSON_THROW_ON_ERROR
From: me@kelunik.com (Niklas Keller)

--001a11428394379170055a162a0a
Content-Type: text/plain; charset="UTF-8"

2017-09-26 12:01 GMT+02:00 Derick Rethans <derick@php.net>:

> On Mon, 25 Sep 2017, Andrea Faulds wrote:
>
> > Hi everyone,
> >
> > https://wiki.php.net/rfc/json_throw_on_error
> >
> > Voting opens today, 2017-09-25, and ends in 10 days' time, 2017-10-05.
> Under
> > the terms of the voting RFC this only needs 50%+1 but I'll feel guilty
> if it's
> > not 2/3 so it's 2/3.
> >
> > Happy voting, please ask if there's anything needing clarifying.
>
> I'm going to be in favour, but I was wondering whether the name of the
> exception "JsonException" is a good thing? I would still introduce it,
> but probably subclass a "JsonCodingException" to signal just an
> exceptional code while encoding/decoding. I can see future exceptions
> being thrown from the extension, where you then get confusion (or
> conflicts with error codes).


Which future exceptions can you imagine?

Regards, Niklas

--001a11428394379170055a162a0a--