Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100775 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97181 invoked from network); 26 Sep 2017 10:02:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Sep 2017 10:02:06 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Received: from [82.113.146.227] ([82.113.146.227:33946] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 78/01-20795-9952AC95 for ; Tue, 26 Sep 2017 06:02:04 -0400 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 3516D10C603; Tue, 26 Sep 2017 11:01:58 +0100 (BST) Date: Tue, 26 Sep 2017 11:01:58 +0100 (BST) X-X-Sender: derick@singlemalt.home.derickrethans.nl To: Andrea Faulds cc: internals@lists.php.net In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [PHP-DEV] [VOTE] JSON_THROW_ON_ERROR From: derick@php.net (Derick Rethans) On Mon, 25 Sep 2017, Andrea Faulds wrote: > Hi everyone, > > https://wiki.php.net/rfc/json_throw_on_error > > Voting opens today, 2017-09-25, and ends in 10 days' time, 2017-10-05. Under > the terms of the voting RFC this only needs 50%+1 but I'll feel guilty if it's > not 2/3 so it's 2/3. > > Happy voting, please ask if there's anything needing clarifying. I'm going to be in favour, but I was wondering whether the name of the exception "JsonException" is a good thing? I would still introduce it, but probably subclass a "JsonCodingException" to signal just an exceptional code while encoding/decoding. I can see future exceptions being thrown from the extension, where you then get confusion (or conflicts with error codes). cheers, Derick -- https://derickrethans.nl | https://xdebug.org | https://dram.io Like Xdebug? Consider a donation: https://xdebug.org/donate.php twitter: @derickr and @xdebug