Push Litespeed SAPI 6.9 to PHP 7.0.1

8 years ago by Tom Sommer — view source

unread

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing our
customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to
get backported into 7.0.1?

The fix is here:
https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
(I believe)

Thanks

Tom Sommer

8 years ago by Lior Kaplan — view source

unread

Hi Tom,

The patch isn't even committed to the 7.0 branch, only exists on master.

And also 7.0.1 is already tagged a few hours ago.

So, do the change on 7.0 branch and it will be part of 7.0.2.

Kaplan

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the Litespeed
6.8 sapi which breaks php_flag and php_value. It's causing our customers a
lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to get
backported into 7.0.1?

The fix is here:
https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
(I believe)

Thanks

Tom Sommer

8 years ago by Lior Kaplan — view source

unread

George,

Can you take a look at Tom's comment about this problem.

Thanks,

Kaplan

Hi Tom,

The patch isn't even committed to the 7.0 branch, only exists on master.

And also 7.0.1 is already tagged a few hours ago.

So, do the change on 7.0 branch and it will be part of 7.0.2.

Kaplan

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing our
customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to get
backported into 7.0.1?

The fix is here:
https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
(I believe)

Thanks

Tom Sommer

8 years ago by Tom Sommer — view source

unread

For some reason Litespeed 6.9 is committed to the 7.0 branch as
Litespeed 6.9, but the bugfix is not included?

https://github.com/php/php-src/blob/PHP-7.0/sapi/litespeed/lsapi_main.c#L604

The bugfix is only found in master.

--
Tom Sommer

George,

Can you take a look at Tom's comment about this problem.

Thanks,

Kaplan

Hi Tom,

The patch isn't even committed to the 7.0 branch, only exists on
master.

And also 7.0.1 is already tagged a few hours ago.

So, do the change on 7.0 branch and it will be part of 7.0.2.

Kaplan

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing
our
customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to
get
backported into 7.0.1?

The fix is here:
https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
(I believe)

Thanks

Tom Sommer

8 years ago by Anatol belski — view source

unread

Hi,

-----Original Message-----

For some reason Litespeed 6.9 is committed to the 7.0 branch as Litespeed
6.9,
but the bugfix is not included?

https://github.com/php/php-src/blob/PHP-
7.0/sapi/litespeed/lsapi_main.c#L604

The bugfix is only found in master.

$ git branch --contains 5bcb7a7019a49c2f80eda7d2aa947efebeee0034
master

So yes, as Lior already told. Probably should be backported to 5.6 as well.

Regards

Anatol

8 years ago by Grzegorz Zdanowski — view source

unread

2015-12-16 19:20 GMT+01:00 Anatol belski ab@php.net:

Hi,

-----Original Message-----

For some reason Litespeed 6.9 is committed to the 7.0 branch as Litespeed
6.9,
but the bugfix is not included?

https://github.com/php/php-src/blob/PHP-
7.0/sapi/litespeed/lsapi_main.c#L604

The bugfix is only found in master.

$ git branch --contains 5bcb7a7019a49c2f80eda7d2aa947efebeee0034
master

So yes, as Lior already told. Probably should be backported to 5.6 as well.

Regards

Anatol

--

Litespeed SAPI should also fix https://bugs.php.net/bug.php?id=71055
It was confirmed by their support
https://www.litespeedtech.com/support/forum/threads/fixed-lsapi-integration-breaks-dir-in-cli.13493/#post-91207

8 years ago by Tom Sommer — view source

unread

That does not explain why
https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
is not backported to 7.0 or 7.0.1?

Tom Sommer

2015-12-16 19:20 GMT+01:00 Anatol belski ab@php.net:

Hi,

-----Original Message-----

For some reason Litespeed 6.9 is committed to the 7.0 branch as Litespeed
6.9,
but the bugfix is not included?

https://github.com/php/php-src/blob/PHP-
7.0/sapi/litespeed/lsapi_main.c#L604

The bugfix is only found in master.

$ git branch --contains 5bcb7a7019a49c2f80eda7d2aa947efebeee0034
master

So yes, as Lior already told. Probably should be backported to 5.6 as
well.

Regards

Anatol

--

Litespeed SAPI should also fix https://bugs.php.net/bug.php?id=71055
It was confirmed by their support
https://www.litespeedtech.com/support/forum/threads/fixed-lsapi-integration-breaks-dir-in-cli.13493/#post-91207

8 years ago by Remi Collet — view source

unread

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 16/12/2015 14:41, Tom Sommer a écrit :

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's
causing our customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible
to get backported into 7.0.1?

The fix is here:
https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efe
beee0034#diff-e8087496f5a642ce83e5d655c08c6b3a

(I believe)

Thanks

Missing in 7.0 see diff-7.0.txt
Missing in 7.0.1 see diff-7.0.1.txt

Remi

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlZyVHoACgkQYUppBSnxahhtRwCgl23H+rKJYFYTQV22pJ/olGV+
hucAoMcUYM8W/rQb/M91lfnUkWZI8tSL
=ofvT
-----END PGP SIGNATURE

8 years ago by Anatol Belski — view source

unread

Hi Remi,

-----Original Message-----
From: Remi Collet [mailto:remi@fedoraproject.org]
Sent: Thursday, December 17, 2015 7:22 AM
To: internals@lists.php.net; gwang@php.net
Subject: Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 16/12/2015 14:41, Tom Sommer a écrit :

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing
our customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to
get backported into 7.0.1?

The fix is here:
https://github.com/php/php-
src/commit/5bcb7a7019a49c2f80eda7d2aa947efe
beee0034#diff-e8087496f5a642ce83e5d655c08c6b3a

(I believe)

Thanks

Missing in 7.0 see diff-7.0.txt
This was missing even before 7.0.0 already, so once it's backported, will be picked up.

Missing in 7.0.1 see diff-7.0.1.txt

Only two critical patches discussed on security@ was applied to 7.0.1, yep. Those make diff with the RC.

Regards

Anatol

8 years ago by Tom Sommer — view source

unread

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing
our customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to
get backported into 7.0.1?

The fix is here:
https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
(I believe)

So noone is going to do anything about this? It's not in 7.0.2 either?

// Tom

8 years ago by Lior Kaplan — view source

unread

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing
our customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to
get backported into 7.0.1?

The fix is here:

https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
(I believe)

So noone is going to do anything about this? It's not in 7.0.2 either?

Hi Tom,

Please contact the original committer to understand why was it done in
master only.

George Wang gwang@php.net

He is the de-facto maintainer for the lightspeed sapi.

Kaplan

8 years ago by Tom Sommer — view source

unread

Hi

I realise 7.0.1 is already out in RC1, but there is a bug in the
Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing
our customers a lot of headaches.

I see Litespeed 6.9 is already in master, but would it be possible to
get backported into 7.0.1?

The fix is here:

https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a
(I believe)

So noone is going to do anything about this? It's not in 7.0.2 either?

Please contact the original committer to understand why was it done in
master only.

George Wang gwang@php.net

He is the de-facto maintainer for the lightspeed sapi.

Pull request into 7.0 branch: https://github.com/php/php-src/pull/1715

I can create one for 7.0.2 also ;)

// Tom