Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89825 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50355 invoked from network); 16 Dec 2015 17:17:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Dec 2015 17:17:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=mail@tomsommer.dk; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=mail@tomsommer.dk; sender-id=pass Received-SPF: pass (pb1.pair.com: domain tomsommer.dk designates 89.188.72.215 as permitted sender) X-PHP-List-Original-Sender: mail@tomsommer.dk X-Host-Fingerprint: 89.188.72.215 tomsommer.dk Linux 2.6 Received: from [89.188.72.215] ([89.188.72.215:33748] helo=tomsommer.dk) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 71/28-51216-DBC91765 for ; Wed, 16 Dec 2015 12:17:49 -0500 Received: from localhost (localhost [127.0.0.1]) by tomsommer.dk (Postfix) with ESMTP id 5CD70937272; Wed, 16 Dec 2015 18:17:46 +0100 (CET) X-Virus-Scanned-By: tomsommer.dk Received: from tomsommer.dk ([127.0.0.1]) by localhost (vip1.zitcom.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5wagUaqDlSNM; Wed, 16 Dec 2015 18:17:46 +0100 (CET) Received: from webmail.tomsommer.dk (localhost [127.0.0.1]) by tomsommer.dk (Postfix) with ESMTP id CA5DD937271; Wed, 16 Dec 2015 18:17:45 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 Dec 2015 18:17:45 +0100 To: Lior Kaplan Cc: George Wang , PHP internals list , Anatol Belski In-Reply-To: References: <38ca88949339f5ac7beb2c479d4352e2@dreamcoder.dk> Message-ID: X-Sender: mail@tomsommer.dk User-Agent: Roundcube Webmail/1.2-git Subject: Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1 From: mail@tomsommer.dk (Tom Sommer) For some reason Litespeed 6.9 is committed to the 7.0 branch as Litespeed 6.9, but the bugfix is not included? https://github.com/php/php-src/blob/PHP-7.0/sapi/litespeed/lsapi_main.c#L604 The bugfix is only found in master. -- Tom Sommer On 2015-12-16 14:52, Lior Kaplan wrote: > George, > > Can you take a look at Tom's comment about this problem. > > Thanks, > > Kaplan > > On Wed, Dec 16, 2015 at 3:51 PM, Lior Kaplan wrote: > >> Hi Tom, >> >> The patch isn't even committed to the 7.0 branch, only exists on >> master. >> >> And also 7.0.1 is already tagged a few hours ago. >> >> So, do the change on 7.0 branch and it will be part of 7.0.2. >> >> Kaplan >> >> On Wed, Dec 16, 2015 at 3:41 PM, Tom Sommer wrote: >> >>> Hi >>> >>> I realise 7.0.1 is already out in RC1, but there is a bug in the >>> Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing >>> our >>> customers a lot of headaches. >>> >>> I see Litespeed 6.9 is already in master, but would it be possible to >>> get >>> backported into 7.0.1? >>> >>> The fix is here: >>> https://github.com/php/php-src/commit/5bcb7a7019a49c2f80eda7d2aa947efebeee0034#diff-e8087496f5a642ce83e5d655c08c6b3a >>> (I believe) >>> >>> Thanks >>> -- >>> Tom Sommer >>> >>> -- >>> PHP Internals - PHP Runtime Development Mailing List >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >>