Question about patch for bug 61285 - SSL connections do not timeout View as Markdown

Hi Brad,

The fix should go to the lowest relevant branch, in this case probably the
5.5 branch.
From there it will be merged to 5.6 and master (future 7.0)/

I took a quick look at the build, and which it compiles successfully,
it seems to be a diff in the test. I suspect it comes from changes in master
than your patch alone (but didn't check this thoroughly).

If someone else wants to look, we're talking about:
https://github.com/php/php-src/pull/971
https://travis-ci.org/php/php-src/jobs/45566082

Kaplan

On Fri, Jan 2, 2015 at 4:46 PM, Brad Broerman bbroerman@bbroerman.net
wrote:

Hi,

I have a pull request for issue 61285 - SSL connections do not
timeout, and have a question about it's status

I created a pull request for this years ago, back in PHP 5.5.20 and
it was never merged into the master. I recently updated my clone of the
repo to the latest and re-wrote my patch against the newly updated
master and re-created the pull request.

Is there a possibility of this being pulled? If not, why? I have
tested this code both in the original 5.5.20, in the new 5.6.4, and
briefly with master. I believe it works pretty well. In the pull
request itself, I added a comment about the travis ci build failing, but
I don't see where the failure has anything to do with this extension.
Would this block acceptance of this patch?

Thanks
Brad Broerman