Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80151
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.214.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54A6BD5A.60601@bbroerman.net>
References: <54A6BD5A.60601@bbroerman.net>
Date: Sun, 4 Jan 2015 15:12:24 +0100
Message-ID: <CAPJnDK3rh-Gg1-B6p3heFWJ71ZqwChsWHRc_u3bgkW=+Gmda2A@mail.gmail.com>
To: Brad Broerman <bbroerman@bbroerman.net>
Cc: PHP internals list <internals@lists.php.net>, Wez Furlong <wez@thebrainroom.com>, 
	Daniel Lowrey <rdlowrey@php.net>, Chris Wright <daverandom@php.net>
Content-Type: multipart/alternative; boundary=089e0112c314b66310050bd4295b
Subject: Re: [PHP-DEV] Question about patch for bug 61285 - SSL connections do
 not timeout
From: lior.k@zend.com (Lior Kaplan)

--089e0112c314b66310050bd4295b
Content-Type: text/plain; charset=UTF-8

Hi Brad,

The fix should go to the lowest relevant branch, in this case probably the
5.5 branch.
From there it will be merged to 5.6 and master (future 7.0)/

I took a quick look at the build, and which it compiles successfully,
it seems to be a diff in the test. I suspect it comes from changes in master
than your patch alone (but didn't check this thoroughly).

If someone else wants to look, we're talking about:
https://github.com/php/php-src/pull/971
https://travis-ci.org/php/php-src/jobs/45566082

Kaplan

On Fri, Jan 2, 2015 at 4:46 PM, Brad Broerman <bbroerman@bbroerman.net>
wrote:

> Hi,
>
>    I have a pull request for issue 61285 - SSL connections do not
> timeout, and have a question about it's status
>
>    I created a pull request for this years ago, back in PHP 5.5.20 and
> it was never merged into the master. I recently updated my clone of the
> repo to the latest and re-wrote my patch against the newly updated
> master and re-created the pull request.
>
>    Is there a possibility of this being pulled? If not, why?  I have
> tested this code both in the original 5.5.20, in the new 5.6.4, and
> briefly with master. I believe it works pretty well.  In the pull
> request itself, I added a comment about the travis ci build failing, but
> I don't see where the failure has anything to do with this extension.
> Would this block acceptance of this patch?
>
>
>  Thanks
>    Brad Broerman
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--089e0112c314b66310050bd4295b--