unread
Nice patches, but could you please provide ones without
the whitespace changes? Now it's not very clear what you
have actually changed..--Jani
Sure. I followed the instructions in README.SUBMITTING_PATCH and only
had "diff -u" in my >.cvsrc. Now I have "diff -uw" and hope this is what
you expect.Massimo
Sorry, I'm afraid Outlook (which I'm forced to use at work) made the
usual mess on the inline attachments. I am resending the patches as in
the first couple of postings.
Please bear with me.
Massimo
unread
okay, here are some comments.
i think you are right that the current oci has a bug with
persitent connections. (likely to be fixed by your patch - just commit that
part)
but i have a problem with the 2 new features:
i don't think that timing out persistent connections should
be done in oci8.c. _if_ we decide that PHP should automatic
close unused persistent connections i really think we should
find a more general solution that will work for all kinds of
persistent connections.
to solve your firewall-kills-idle-oracle-connections problem
just configure a TNS failover to the same oracle instance in
tnsnames.ora: (something down the lines)
failover =
(DESCRIPTION =
(ADDRESS = (PROTOCOL= TCP)(Host= 127.0.0.1)(Port= 1521))
(CONNECT_DATA = (SID=DC4) (failover_mode=(backup=failover)(type=session)(method=basic)(retry=100)(delay=60)))
)
re the uppercasing of oracle-credentials: even if -no matter what
authentication method you use- all oracle credentials are case
insensitive today, can you guarantee they will be tomorrow?
i think this patch adresses a problem that does not exist. if
ppls do ociplogin("scott","tiger") and later ociplogon("SCOTT","TIGER")
they *deserve* do waste one persistent connection:-) also note that the
*same* "problem" exists in all other php db-drivers AFAICS.
regards,
tc