Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:818
Return-Path: <thies@thiesos.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 15901 invoked from network); 9 Apr 2003 07:20:41 -0000
Received: from unknown (HELO thiesos.org) (213.39.130.15)
  by pb1.pair.com with SMTP; 9 Apr 2003 07:20:41 -0000
Received: by thiesos.org (Postfix, from userid 1000)
	id 07708FA9A8; Wed,  9 Apr 2003 09:20:39 +0200 (CEST)
Date: Wed, 9 Apr 2003 09:20:39 +0200
To: SQUILLACE MASSIMO <msquillace@sogei.it>
Cc: Jani Taskinen <sniper@iki.fi>, internals@lists.php.net
Message-ID: <20030409072038.GB31738@schnuffel.thieso.net>
References: <7410A5117CDC9C4CA07FBC870D65A50D1B4BB5@MAILBOX01.domus.ad.sogei.it>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <7410A5117CDC9C4CA07FBC870D65A50D1B4BB5@MAILBOX01.domus.ad.sogei.it>
User-Agent: Mutt/1.4i
Subject: Re: [PHP-DEV] R: [PHP-DEV] [PATCH] OCI8 module - proposed patches (PART 1 of 2)
From: thies@thiesos.org ("Thies C. Arntzen")

    
    okay, here are some comments.

    i think you are right that the current oci has a bug with
    persitent connections. (likely to be fixed by your patch - just commit that
    part)


    but i have a problem with the 2 new features:

    i don't think that timing out persistent connections should
    be done in oci8.c. _if_ we decide that PHP should automatic
    close unused persistent connections i really think we should
    find a more general solution that will work for all kinds of
    persistent connections.

    to solve your firewall-kills-idle-oracle-connections problem
    just configure a TNS failover to the same oracle instance in
    tnsnames.ora: (something down the lines)

failover =
  (DESCRIPTION =
    (ADDRESS = (PROTOCOL= TCP)(Host= 127.0.0.1)(Port= 1521))
    (CONNECT_DATA = (SID=DC4) (failover_mode=(backup=failover)(type=session)(method=basic)(retry=100)(delay=60)))
  )

    re the uppercasing of oracle-credentials: even if -no matter what
    authentication method you use- all oracle credentials are case 
    insensitive today, can you guarantee they will be tomorrow? 
    i think this patch adresses a problem that does not exist. if 
    ppls do ociplogin("scott","tiger") and later ociplogon("SCOTT","TIGER")
    they *deserve* do waste one persistent connection:-) also note that the
    *same* "problem" exists in all other php db-drivers AFAICS.

    regards,
    tc