Hi
While browsing over some of the code base, I felt over
ftp_ssl_connect(), which we only enable in our builds if the openssl
extension is available, and even then, we only enable it if it is
built statically. I have hacked the code a little, so instead of
adding a dependency on a static ext/openssl, we will now detect the
openssl library and link it directly if it is found during configure,
meaning that in our public builds of PHP on Windows, this function
will now always be available.
There is however the concern whether or not this makes sense to link
to openssl for just this function, and I would love some more input on
this matter from someone more experienced as I'm a little rusty.
Attached is the patch I have made, note that it does not touch the
config.m4, which will need a friendly hand from someone familiar with
the UNIX build system.
--
regards,
Kalle Sommer Nielsen
kalle@php.net
Attached is the patch I have made, note that it does not touch the
config.m4, which will need a friendly hand from someone familiar with
the UNIX build system.
I see no attachment. Did you forget to attach it? Failing that, maybe the mailing list strips attachments, in which case I suggest making a gist with the patch in it.
--
Andrea Faulds
http://ajf.me/
Attached is the patch I have made, note that it does not touch the
config.m4, which will need a friendly hand from someone familiar with
the UNIX build system.I see no attachment. Did you forget to attach it? Failing that, maybe the
mailing list strips attachments, in which case I suggest making a gist with
the patch in it.--
Andrea Faulds
http://ajf.me/--
afair we only allow attachment with .txt extension
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
2014-06-07 9:26 GMT+02:00 Kalle Sommer Nielsen kalle@php.net:
Since I forgot the ML only accepts .txt, here is the correct patch file:
http://pastie.org/9269731
--
regards,
Kalle Sommer Nielsen
kalle@php.net
Since I forgot the ML only accepts .txt, here is the correct patch file:
http://pastie.org/9269731
I don't think this is a good approach, either we link a lib or not.
Given current state of the Web and increasing security requirements I'd
prefer to make SSL a default feature, while I can understand "issues"
while installing PHP (especially fro zip file) in regards to the openssl
library dll on Windows.
johannes