Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:74778
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.170 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
Date: Sat, 7 Jun 2014 09:26:44 +0200
Message-ID: <CAJW__o3RdiXnaJVBNnAY6EzS3C0f=6ocrGjzFVDYSc+0o02S3g@mail.gmail.com>
To: Internals <internals@lists.php.net>
Content-Type: multipart/mixed; boundary=047d7b6dc7a470755504fb39e650
Subject: Regarding ftp_ssl_connect()
From: kalle@php.net (Kalle Sommer Nielsen)

--047d7b6dc7a470755504fb39e650
Content-Type: text/plain; charset=UTF-8

Hi

While browsing over some of the code base, I felt over
ftp_ssl_connect(), which we only enable in our builds if the openssl
extension is available, and even then, we only enable it if it is
built statically. I have hacked the code a little, so instead of
adding a dependency on a static ext/openssl, we will now detect the
openssl library and link it directly if it is found during configure,
meaning that in our public builds of PHP on Windows, this function
will now always be available.

There is however the concern whether or not this makes sense to link
to openssl for just this function, and I would love some more input on
this matter from someone more experienced as I'm a little rusty.

Attached is the patch I have made, note that it does not touch the
config.m4, which will need a friendly hand from someone familiar with
the UNIX build system.

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net

--047d7b6dc7a470755504fb39e650--