RFC: Catchable "call to a member function of a non-object" View as Markdown

Hi Johannes,
 

The definition of E_ERROR is "an error where the engine can't fully
recover", so if we can recover there should be no need for a vote ;-)
 
:)

But I have doubts whether this works reliably in all cases where
functions are called. i.e. how will usort() behave?
 
You're right, there's not test for this. I've added two phpt-files
showing this does not corrupt eval() or calls inside usort():
 
https://github.com/thekid/php-src/commit/da1db5e688c46a044bc0745c86cc34cc4e9ab808
https://github.com/thekid/php-src/commit/7041ef44a6c18bb8d76dc5cf17d20ec00367d24b

From a very quick grep it seems that i.e. sapi/phpdbg doesn't check the
return value of zend_call_function, these things have to be reviewed too.

Good point! Looking into the details of my implementation again though,
this cannot lead to a problem AFAIS, zend_call_function() will return
cleanly in any case. I'm not firm with sapi/phpdbg's usage, could you point
to where you think I'd start seeing a problem?

What I've tried so far is:

$ cat dbg.php
<?php
set_error_handler(function($code, $message) {
  var_dump($code, $message);
}, E_RECOVERABLE_ERROR);

$comparator= null;
var_dump($comparator->compare(1, 2));
echo "Alive\n";

$ ./sapi/phpdbg/phpdbg
[Welcome to phpdbg, the interactive PHP debugger, v0.3.2]
To get help using phpdbg type "help" and press enter
[Please report bugs to http://github.com/krakjoe/phpdbg/issues]
phpdbg> exec dbg.php
[Set execution context: /home/friebe/devel/php-src/dbg.php]
phpdbg> compile
[Attempting compilation of /home/friebe/devel/php-src/dbg.php]
[Success]
phpdbg> run
int(4096)
string(51) "Call to a member function compare() on a non-object"
NULL
Alive
phpdbg>

...and also "step 1" and the "next"ing through the code, without any surprises.

• Timm

Derick Rethans wrote on 29.04.2014 10:26:

Hello everyone,

as per the RFC process I'd like to start a discussion on the RFC
I've put up on the RFC Wiki:

  https://wiki.php.net/rfc/catchable-call-to-member-of-non-object
  RFC: Catchable "call to a member function of a non-object", 1.0

The essence of this pull request is that it converts this fatal error
into E_RECOVERABLE_ERRORs. Framework authors may choose to convert
these into exceptions, as they already do with argument type mismatches.

Feedback is welcome!

Besides the technical issues that Johannes already mentions, I am also
against this for logic reasons.

Calling methods on NULL objects is a programming mistake. You either
have a bug in the code that creates the objects, and in cases where it
is somethings OK to not have an object, you forgot to check whether you
have an objects. Programming mistakes should not be hidden by error
handlers.

Hello Derick,

the RFC is not about hiding programming mistakes, it is still possible to return false in the error handler.
Btw. PHP tolerates a lot of programming mistakes, see Warning, Notice and that's why we like PHP.
In most cases (like concurrent deletes), additional checks take a lot of time for implementation and testing and in most cases, the code is never executed.
There are many functions (like mysqli::query, mysqli::prepare) that return false|null|object. Covering everything with if(...) makes the code bigger and less readable.

Regards,
Thomas

Programming mistakes should not be hidden by error

Of course, but what about having a PHPUnit tests that hard-fail due to a
"PHP Fatal error: Call to a member function foo() on a non-object in ..."?

Just being able to have a handler that catches it as an error is pretty ok,
and it surely allows me to see if there are other failures in a huge test
suite
without having to come up with some crazy code just to run the tests one by
one.

This use case already makes it worth having this improvement in my opinion.

Cheers,

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/