Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73835
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain thekid.de from 212.227.17.13 cause and error)
Date: Mon, 28 Apr 2014 22:35:40 +0200 (CEST)
Reply-To: Timm Friebe <php@thekid.de>
To: =?UTF-8?Q?=22Johannes_Schl=C3=BCter=22?= <johannes@schlueters.de>
Cc: internals@lists.php.net
Message-ID: <811192582.486350.1398717340893.open-xchange@email.1und1.de>
In-Reply-To: <1398676031.26923.36.camel@guybrush>
References: <1005082480.406481.1398600039315.open-xchange@email.1und1.de> <1398676031.26923.36.camel@guybrush>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Importance: Medium
Subject: Re: [PHP-DEV] RFC: Catchable "call to a member function of a
 non-object"
From: php@thekid.de (Timm Friebe)

Hi Johannes,
=C2=A0
> The definition of E_ERROR is "an error where the engine can't fully
> recover", so if we can recover there should be no need for a vote ;-)
=C2=A0
:)

> But I have doubts whether this works reliably in all cases where
> functions are called. i.e. how will usort() behave?
=C2=A0
You're right, there's not test for this. I've added two phpt-files
showing this does not corrupt eval() or calls inside usort():
=C2=A0
https://github.com/thekid/php-src/commit/da1db5e688c46a044bc0745c86cc34cc4e=
9ab808
https://github.com/thekid/php-src/commit/7041ef44a6c18bb8d76dc5cf17d20ec003=
67d24b

> From a very quick grep it seems that i.e. sapi/phpdbg doesn't check the
> return value of zend_call_function, these things have to be reviewed too.

Good point! Looking into the details of my implementation again though,
this cannot lead to a problem AFAIS, zend_call_function() will return
cleanly in any case. I'm not firm with sapi/phpdbg's usage, could you point
to where you think I'd start seeing a problem?

What I've tried so far is:

$ cat dbg.php
<?php
set_error_handler(function($code, $message) {
=C2=A0 var_dump($code, $message);
}, E_RECOVERABLE_ERROR);

$comparator=3D null;
var_dump($comparator->compare(1, 2));
echo "Alive\n";

$ ./sapi/phpdbg/phpdbg
[Welcome to phpdbg, the interactive PHP debugger, v0.3.2]
To get help using phpdbg type "help" and press enter
[Please report bugs to <http://github.com/krakjoe/phpdbg/issues>]
phpdbg> exec dbg.php
[Set execution context: /home/friebe/devel/php-src/dbg.php]
phpdbg> compile
[Attempting compilation of /home/friebe/devel/php-src/dbg.php]
[Success]
phpdbg> run
int(4096)
string(51) "Call to a member function compare() on a non-object"
NULL
Alive
phpdbg>

...and also "step 1" and the "next"ing through the code, without any surpri=
ses.


- Timm