uniqid() is not unique under windows

Hi Yasuo,

Hi Pierre,

Why is uniqid() is not guarantee uniqueness under windows?

https://bugs.php.net/bug.php?id=65626

its base are microseconds, so nothing prevents to usleep() in user space.
It's also documented to be nonsecure, so isn't it just the expected
behavior?

It seems PHP_WIN32 and CYGWIN check is obsolete.
Could it be removed?

Never compiled with cygwin. However what stands in the code might be true
needed, as cygwin is proxying native APIs, so it is expected to be much
slowlier. Maybe there are other reasons for that, though.

Regards

Anatol

Hi Pierre,

Why is uniqid() is not guarantee uniqueness under windows?

https://bugs.php.net/bug.php?id=65626

It seems PHP_WIN32 and CYGWIN check is obsolete.
Could it be removed?

Not sure, we have to test to see if it is necessary.

But for cygwin, we do not support it so I won't do any testing with it.

Cheers,

Pierre

@pierrejoye | http://www.libgd.org