Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:72421 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88775 invoked from network); 9 Feb 2014 23:34:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Feb 2014 23:34:14 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.181 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.181 mail-lb0-f181.google.com Received: from [209.85.217.181] ([209.85.217.181:63697] helo=mail-lb0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E7/70-17837-47018F25 for ; Sun, 09 Feb 2014 18:34:13 -0500 Received: by mail-lb0-f181.google.com with SMTP id z11so3193455lbi.26 for ; Sun, 09 Feb 2014 15:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=8Wg1fHHzIN31I1rJIZEKfDinTkNPDMpW/nk9/0x5cgs=; b=gnvnx4nq4hh6bJnSvvyVBSYw2KKhi8/grHEPPkxto3RgeWBaVjscBJ10lXeq/LCUcF AWzn90jQmGAzuAiH52wCZJ465XrfhL1eSLRJibPADxMW0fNkPOTrR1i2LR65nvXAwHlP lF2KSr4qG7upjcGl9TQ2nZo6jCvt9Kihhtc2dVdg1AOaYt5AD+DVCM656+WIEbXaxPSx 0oA+M74dbA4yEdLysmNteeyb9yeYHl2BF1jQLlhkbeTSa7Y+AwePSdcJ7zFAynyx8iKu OzaCFY2oLVBF1e+nGXULmi4yXaBJZvZOjhOyzusaUbkEBmeZf3NDKv7DFvoxHEkc9Twd h6ug== X-Received: by 10.152.43.103 with SMTP id v7mr2542133lal.46.1391988849471; Sun, 09 Feb 2014 15:34:09 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.199.37 with HTTP; Sun, 9 Feb 2014 15:33:29 -0800 (PST) In-Reply-To: References: Date: Mon, 10 Feb 2014 08:33:29 +0900 X-Google-Sender-Auth: tRjhtWf7MwlHSfelCxDtuDqMyqA Message-ID: To: Pierre Joye Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a11c34dcae7761104f201a86d Subject: Re: uniqid() is not unique under windows From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11c34dcae7761104f201a86d Content-Type: text/plain; charset=UTF-8 Hi all, On Sun, Feb 9, 2014 at 7:20 AM, Pierre Joye wrote: > On Sat, Feb 8, 2014 at 10:14 PM, Yasuo Ohgaki wrote: > > Hi Pierre, > > > > Why is uniqid() is not guarantee uniqueness under windows? > > > > https://bugs.php.net/bug.php?id=65626 > > > > It seems PHP_WIN32 and __CYGWIN__ check is obsolete. > > Could it be removed? > > Not sure, we have to test to see if it is necessary. > > But for cygwin, we do not support it so I won't do any testing with it. https://github.com/yohgaki/php-src/commit/6c36a82ee84cfda0cb14c95b0c035849f73d8354 Here is simple patch to test for windows. Could anyone try to see if it works? According to PHP_FUNCTION(microtime), it should work. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11c34dcae7761104f201a86d--